diff options
| author | Hannes Hörl <hhorl@pivotal.io> | 2019-02-14 15:10:52 +0000 |
|---|---|---|
| committer | Maria Ntalla <mntalla@pivotal.io> | 2019-02-14 15:10:52 +0000 |
| commit | f87e0f084c2636a8ba8ed8674faa25b59087c533 (patch) | |
| tree | 17349ca8ede8d82b29b36ea8ed356a024a1d445d /contributors/guide/github-workflow.md | |
| parent | b79961c65f4b19ebbfbd45b1c0d39ba4c71dd249 (diff) | |
| parent | 665611b75a772677978e6a544690d27a20d75565 (diff) | |
Merge remote-tracking branch 'upstream/master' into contrib-test-debug
Signed-off-by: Maria Ntalla <mntalla@pivotal.io>
Diffstat (limited to 'contributors/guide/github-workflow.md')
| -rw-r--r-- | contributors/guide/github-workflow.md | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/contributors/guide/github-workflow.md b/contributors/guide/github-workflow.md index 221a7921..cef4e0a3 100644 --- a/contributors/guide/github-workflow.md +++ b/contributors/guide/github-workflow.md @@ -149,17 +149,17 @@ make test make test WHAT=./pkg/api/helper GOFLAGS=-v # Run integration tests, requires etcd -# For more info, visit https://git.k8s.io/community/contributors/devel/testing.md#integration-tests +# For more info, visit https://git.k8s.io/community/contributors/devel/sig-testing/testing.md#integration-tests make test-integration # Run e2e tests by building test binaries, turn up a test cluster, run all tests, and tear the cluster down # Equivalent to: go run hack/e2e.go -- -v --build --up --test --down # Note: running all e2e tests takes a LONG time! To run specific e2e tests, visit: -# https://git.k8s.io/community/contributors/devel/e2e-tests.md#building-kubernetes-and-running-the-tests +# https://git.k8s.io/community/contributors/devel/sig-testing/e2e-tests.md#building-kubernetes-and-running-the-tests make test-e2e ``` -See the [testing guide](/contributors/devel/testing.md) and [end-to-end tests](/contributors/devel/e2e-tests.md) +See the [testing guide](/contributors/devel/sig-testing/testing.md) and [end-to-end tests](/contributors/devel/sig-testing/e2e-tests.md) for additional information and scenarios. Run `make help` for additional information on these make targets. @@ -199,7 +199,7 @@ git push -f ${your_remote_name} myfeature ### 7 Create a pull request -1. Visit your fork at https://github.com/$user/kubernetes +1. Visit your fork at `https://github.com/$user/kubernetes` 2. Click the `Compare & Pull Request` button next to your `myfeature` branch. 3. Check out the pull request [process](/contributors/guide/pull-requests.md) for more details and advice. @@ -219,10 +219,6 @@ Commit changes made in response to review comments to the same branch on your fork. Very small PRs are easy to review. Very large PRs are very difficult to review. -At the assigned reviewer's discretion, a PR may be switched to use -[Reviewable](https://reviewable.k8s.io) instead. Once a PR is switched to -Reviewable, please ONLY send or reply to comments through Reviewable. Mixing -code review tools can be very confusing. #### Squash and Merge |