From af988769d2eeb2dedb3373670aa3a9643c611064 Mon Sep 17 00:00:00 2001 From: eduartua Date: Wed, 30 Jan 2019 12:55:10 -0600 Subject: e2e-test.md file moved to the new /devel/-sig-testing folder - URLs updated - tombstone files created --- contributors/guide/github-workflow.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'contributors/guide/github-workflow.md') diff --git a/contributors/guide/github-workflow.md b/contributors/guide/github-workflow.md index 221a7921..a50643f0 100644 --- a/contributors/guide/github-workflow.md +++ b/contributors/guide/github-workflow.md @@ -155,11 +155,11 @@ make test-integration # Run e2e tests by building test binaries, turn up a test cluster, run all tests, and tear the cluster down # Equivalent to: go run hack/e2e.go -- -v --build --up --test --down # Note: running all e2e tests takes a LONG time! To run specific e2e tests, visit: -# https://git.k8s.io/community/contributors/devel/e2e-tests.md#building-kubernetes-and-running-the-tests +# https://git.k8s.io/community/contributors/devel/sig-testing/e2e-tests.md#building-kubernetes-and-running-the-tests make test-e2e ``` -See the [testing guide](/contributors/devel/testing.md) and [end-to-end tests](/contributors/devel/e2e-tests.md) +See the [testing guide](/contributors/devel/sig-testing/testing.md) and [end-to-end tests](/contributors/devel/sig-testing/e2e-tests.md) for additional information and scenarios. Run `make help` for additional information on these make targets. -- cgit v1.2.3 From 06a2a2f6867baf35c4b35fcccef872482938854f Mon Sep 17 00:00:00 2001 From: eduartua Date: Wed, 30 Jan 2019 13:26:54 -0600 Subject: file testing.md moved to the new folder /devel/sig-testing - URLs updated - tombstone file created --- contributors/guide/github-workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'contributors/guide/github-workflow.md') diff --git a/contributors/guide/github-workflow.md b/contributors/guide/github-workflow.md index a50643f0..cc1e7e8f 100644 --- a/contributors/guide/github-workflow.md +++ b/contributors/guide/github-workflow.md @@ -149,7 +149,7 @@ make test make test WHAT=./pkg/api/helper GOFLAGS=-v # Run integration tests, requires etcd -# For more info, visit https://git.k8s.io/community/contributors/devel/testing.md#integration-tests +# For more info, visit https://git.k8s.io/community/contributors/devel/sig-testing/testing.md#integration-tests make test-integration # Run e2e tests by building test binaries, turn up a test cluster, run all tests, and tear the cluster down -- cgit v1.2.3 From a095f16dc8de303eb8ae104a231b8ab85a5a76d9 Mon Sep 17 00:00:00 2001 From: ramnar Date: Tue, 5 Feb 2019 20:14:42 +0530 Subject: Broken Links fix for 2696 (#3171) * broken links fix in kubernetes community * Broken Links bug fix * Implemented Review Comments * Implemented Review Comments --- contributors/guide/github-workflow.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'contributors/guide/github-workflow.md') diff --git a/contributors/guide/github-workflow.md b/contributors/guide/github-workflow.md index cc1e7e8f..cef4e0a3 100644 --- a/contributors/guide/github-workflow.md +++ b/contributors/guide/github-workflow.md @@ -199,7 +199,7 @@ git push -f ${your_remote_name} myfeature ### 7 Create a pull request -1. Visit your fork at https://github.com/$user/kubernetes +1. Visit your fork at `https://github.com/$user/kubernetes` 2. Click the `Compare & Pull Request` button next to your `myfeature` branch. 3. Check out the pull request [process](/contributors/guide/pull-requests.md) for more details and advice. @@ -219,10 +219,6 @@ Commit changes made in response to review comments to the same branch on your fork. Very small PRs are easy to review. Very large PRs are very difficult to review. -At the assigned reviewer's discretion, a PR may be switched to use -[Reviewable](https://reviewable.k8s.io) instead. Once a PR is switched to -Reviewable, please ONLY send or reply to comments through Reviewable. Mixing -code review tools can be very confusing. #### Squash and Merge -- cgit v1.2.3