summaryrefslogtreecommitdiff
path: root/src/option_manager.hh
diff options
context:
space:
mode:
authorMaxime Coste <mawww@kakoune.org>2017-05-22 10:31:56 +0100
committerMaxime Coste <mawww@kakoune.org>2017-05-22 10:31:56 +0100
commitbc11e52960e025c4ae6bcde796facca1ff1a7cdc (patch)
treea9f2e6197719f34b54c2501e91a84f5661d567df /src/option_manager.hh
parentbdcfe308341edc47df628c0ff753f2cd39479273 (diff)
Remove virtual destructor from OptionManagerWatcher
We should never destruct anything through an OptionManagerWatcher pointer, so having all those destructor virtual makes no sense.
Diffstat (limited to 'src/option_manager.hh')
-rw-r--r--src/option_manager.hh4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/option_manager.hh b/src/option_manager.hh
index f68f6662..2970d4e2 100644
--- a/src/option_manager.hh
+++ b/src/option_manager.hh
@@ -70,8 +70,6 @@ protected:
class OptionManagerWatcher
{
public:
- virtual ~OptionManagerWatcher() = default;
-
virtual void on_option_changed(const Option& option) = 0;
};
@@ -79,7 +77,7 @@ class OptionManager : private OptionManagerWatcher
{
public:
OptionManager(OptionManager& parent);
- ~OptionManager() override;
+ ~OptionManager();
Option& operator[] (StringView name);
const Option& operator[] (StringView name) const;