Merge overlapping selections before replacing characters

Without doing this, replace with multiple selection at buffer end
breaks as the first selection will replace the end-of-line with a
non-eol character, then a new eol will automatically be added which
will put remaining selections past the end of the buffer.

Fixes #5316

1 files changed, 4 insertions, 2 deletions

diff --git a/src/normal.cc b/src/normal.cc
index d2318865..a2a2504b 100644
--- a/src/normal.cc
+++ b/src/normal.cc
@@ -448,10 +448,12 @@ void replace_with_char(Context& context, NormalParams)
         ScopedEdition edition(context);
         ScopedSelectionEdition selection_edition{context};
         Buffer& buffer = context.buffer();
-        context.selections().for_each([&](size_t index, Selection& sel) {
+        auto& sels = context.selections();
+        sels.merge_overlapping();
+        sels.for_each([&](size_t index, Selection& sel) {
             CharCount count = char_length(buffer, sel);
             replace(buffer, sel, String{*cp, count});
-        }, false);
+        }, true);
     }, "replace with char", "enter char to replace with\n");
 }