Split InsertMode into InsertMode and PasteMode

They are quite different use cases, and this allow moving InsertMode
to input_handler.hh which is what uses it.

This also cleans up the code as we can get rid of get_insert_pos and
rely more on SelectionList::for_each.

1 files changed, 8 insertions, 6 deletions

diff --git a/src/input_handler.cc b/src/input_handler.cc
index 85904e7f..fbfadf81 100644
--- a/src/input_handler.cc
+++ b/src/input_handler.cc
@@ -1467,13 +1467,19 @@ private:
 
     void insert(ConstArrayView<String> strings)
     {
-        context().selections().insert(strings, InsertMode::InsertCursor);
+        context().selections().for_each([strings, &buffer=context().buffer()]
+                                        (size_t index, Selection& sel) {
+            Kakoune::insert(buffer, sel, sel.cursor(), strings[std::min(strings.size()-1, index)]);
+        });
     }
 
     void insert(Codepoint key)
     {
         String str{key};
-        context().selections().insert(str, InsertMode::InsertCursor);
+        context().selections().for_each([&buffer=context().buffer(), &str]
+                                        (size_t index, Selection& sel) {
+            Kakoune::insert(buffer, sel, sel.cursor(), str);
+        });
         context().hooks().run_hook(Hook::InsertChar, str, context());
     }
 
@@ -1551,10 +1557,6 @@ private:
                 sel.set(pos);
             }
             break;
-        case InsertMode::InsertAtNextLineBegin:
-        case InsertMode::InsertCursor:
-             kak_assert(false); // invalid for interactive insert
-             break;
         }
         selections.check_invariant();
         buffer.check_invariant();