Fix crash on redraw in BufCloseFifo hook

FifoWatcher::read_fifo() deletes the fifo watcher in

	m_buffer.values().erase(fifo_watcher_id); // will delete this

which calls:           HashMap::unordered_remove()
                           constexpr_swap(m_items[index], m_items.back());
destructor called here --> m_items.pop_back();
                           m_index.remove(hash, index);

So hash map invariants (of buffer.values()) are broken, when calling
~FifoWatcher which fires BufCloseFifo hooks. Things blow up if those
hooks access buffer.values() such as by accessing cached highlighters
to redraw the buffer.  A shell call with a long sleep in the client
context seems to trigger this.

Fix this by destroying removed map items only at the end of
HashMap::remove(), when invariants are restored.  Alternatively, we
could introduce a fifo_trash container; I haven't explored that.

0 files changed, 0 insertions, 0 deletions