summaryrefslogtreecommitdiff
path: root/src/context.hh
diff options
context:
space:
mode:
authorJohannes Altmanninger <aclopte@gmail.com>2022-08-15 22:21:53 +0200
committerJohannes Altmanninger <aclopte@gmail.com>2022-09-02 02:59:47 +0200
commitc2ab5d46940bb01ab4ab2b4ef82b6829ddbadb5c (patch)
treee39c2eb2a16e58b7df486890a0a8c82fa9ac8c6f /src/context.hh
parentdd4ba2ee88747616f7125024b192cec75cd7e58c (diff)
Allow to undo and redo selection changes
From the issue: > It often happens to me that I carefully craft a selection with multiple > cursors, ready to make changes elegantly, only to completely mess it > up by pressing a wrong key (by merging the cursors for example). Being > able to undo the last selection change (even if only until the previous > buffer change) would make this much less painful. Fix this by recording selection changes and allowing simple linear undo/redo of selection changes. The preliminary key bindings are <c-h> and <c-k>. Here are some other vacant normal mode keys I considered X Y <backspace> <minus> # ^ = <plus> ' unfortunately none of them is super convenient to type. Maybe we can kick out some other normal mode command? --- This feature has some overlap with the jump list (<c-o>/<c-i>) and with undo (u) but each of the three features have their moment. Currently there's no special integration with either peer feature; the three histories are completely independent. In future we might want to synchronize them so we can implement Sublime Text's "Soft undo" feature. Note that it is possible to restore selections that predate a buffer modification. Depending on the buffer modification, the selections might look different of course. (When trying to apply an old buffer's selection to the new buffer, Kakoune computes a diff of the buffers and updates the selection accordingly. This works quite well for many practical examples.) This makes us record the full history of all selections for each client. This seems wasteful, we could set a limit. I don't expect excessive memory usage in practice (we also keep the full history of buffer changes) but I could be wrong. Closes #898
Diffstat (limited to 'src/context.hh')
-rw-r--r--src/context.hh55
1 files changed, 50 insertions, 5 deletions
diff --git a/src/context.hh b/src/context.hh
index a855d243..3f8fbc02 100644
--- a/src/context.hh
+++ b/src/context.hh
@@ -72,7 +72,7 @@ public:
Context& operator=(const Context&) = delete;
Buffer& buffer() const;
- bool has_buffer() const { return (bool)m_selections; }
+ bool has_buffer() const { return not m_selection_history.empty(); }
Window& window() const;
bool has_window() const { return (bool)m_window; }
@@ -90,7 +90,11 @@ public:
// Return potentially out of date selections
SelectionList& selections_write_only();
- void change_buffer(Buffer& buffer);
+ void end_selection_edition() { m_selection_history.end_edition(); }
+ void undo_selection_change();
+ void redo_selection_change();
+
+ void change_buffer(Buffer& buffer, Optional<FunctionRef<void()>> set_selection = {});
void forget_buffer(Buffer& buffer);
void set_client(Client& client);
@@ -113,6 +117,7 @@ public:
bool is_editing() const { return m_edition_level!= 0; }
void disable_undo_handling() { m_edition_level = -1; }
+ bool is_editing_selection() const { return m_selection_history.in_edition(); }
NestedBool& hooks_disabled() { return m_hooks_disabled; }
const NestedBool& hooks_disabled() const { return m_hooks_disabled; }
@@ -145,6 +150,7 @@ private:
size_t m_edition_timestamp = 0;
friend struct ScopedEdition;
+ friend struct ScopedSelectionEdition;
Flags m_flags = Flags::None;
@@ -152,7 +158,45 @@ private:
SafePtr<Window> m_window;
SafePtr<Client> m_client;
- Optional<SelectionList> m_selections;
+ class SelectionHistory {
+ public:
+ SelectionHistory(Context& context);
+ SelectionHistory(Context& context, SelectionList selections);
+ void initialize(SelectionList selections);
+ bool empty() const { return m_history.empty() and not m_staging; }
+ SelectionList& selections(bool update = true);
+
+ void begin_edition();
+ void end_edition();
+ bool in_edition() const { return m_in_edition; }
+
+ void undo();
+ void redo();
+ void forget_buffer(Buffer& buffer);
+ private:
+ enum class HistoryId : size_t { First = 0, Invalid = (size_t)-1 };
+
+ struct HistoryNode
+ {
+ HistoryNode(SelectionList selections, HistoryId parent) : selections(selections), parent(parent) {}
+
+ SelectionList selections;
+ HistoryId parent;
+ HistoryId redo_child = HistoryId::Invalid;
+ };
+
+ HistoryId next_history_id() const noexcept { return (HistoryId)m_history.size(); }
+ HistoryNode& history_node(HistoryId id) { return m_history[(size_t)id]; }
+ const HistoryNode& history_node(HistoryId id) const { return m_history[(size_t)id]; }
+ HistoryNode& current_history_node() { kak_assert((size_t)m_history_id < m_history.size()); return m_history[(size_t)m_history_id]; }
+
+ Context& m_context;
+ Vector<HistoryNode> m_history;
+ HistoryId m_history_id = HistoryId::Invalid;
+ Optional<HistoryNode> m_staging;
+ NestedBool m_in_edition;
+ };
+ SelectionHistory m_selection_history;
String m_name;
@@ -184,11 +228,12 @@ struct ScopedSelectionEdition
{
ScopedSelectionEdition(Context& context)
: m_context{context},
- m_buffer{context.has_buffer() ? &context.buffer() : nullptr} {}
+ m_buffer{context.has_buffer() ? &context.buffer() : nullptr}
+ { if (m_buffer) m_context.m_selection_history.begin_edition(); }
ScopedSelectionEdition(ScopedSelectionEdition&& other) : m_context{other.m_context}, m_buffer{other.m_buffer}
{ other.m_buffer = nullptr; }
- ~ScopedSelectionEdition() {}
+ ~ScopedSelectionEdition() { if (m_buffer) m_context.m_selection_history.end_edition(); }
private:
Context& m_context;
SafePtr<Buffer> m_buffer;