Make String able to reference external data without copying

Sometimes we really need to have a String instead of a StringView,
but some of those strings might not need to own their data. Make
it possible to explicitely construct a String that does not own
the underlying buffer.

Use it when parsing balanced strings.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/command_manager.cc b/src/command_manager.cc
index 42e7f802..f777eeda 100644
--- a/src/command_manager.cc
+++ b/src/command_manager.cc
@@ -121,11 +121,11 @@ QuotedResult parse_quoted_balanced(Reader& reader, char opening_delimiter,
         {
             auto content = reader.substr_from(start);
             ++reader.pos;
-            return {content.str(), true};
+            return {String{String::NoCopy{}, content}, true};
         }
         ++reader.pos;
     }
-    return {reader.substr_from(start).str(), false};
+    return {String{String::NoCopy{}, reader.substr_from(start)}, false};
 }
 
 String parse_unquoted(Reader& reader)