Prevent deletion of buffers while creating new windows

`kak -n -E 'hook global WinCreate .* %{ delete-buffer }'` was crashing
because we would delete the buffer during window construction, which
would not be able to delete the window as it was not fully constructed
and registered yet. This led to a window referencing a deleted buffer.

Fixing this by deleting the window later on failed because we can enter
an infinite loop where we constantly create a new *scratch* buffer, then
a window to display it, which deletes that buffer.

Make it an error to try to delete a buffer while a new window is
being setup by adding a Locked flag to buffers and checking that in
BufferManager::delete_buffer

Fixes #5311

1 files changed, 3 insertions, 0 deletions

diff --git a/src/client.cc b/src/client.cc
index da4ed9f0..2cb1c973 100644
--- a/src/client.cc
+++ b/src/client.cc
@@ -194,6 +194,9 @@ void Client::change_buffer(Buffer& buffer, Optional<FunctionRef<void()>> set_sel
     if (m_buffer_reload_dialog_opened)
         close_buffer_reload_dialog();
 
+    buffer.flags() |= Buffer::Flags::Locked;
+    OnScopeEnd unlock{[&] { buffer.flags() &= ~Buffer::Flags::Locked; }};
+
     auto& client_manager = ClientManager::instance();
     WindowAndSelections ws = client_manager.get_free_window(buffer);