Cleanup replaced range selection logic

Do not access Buffer::m_changes to find the inserted range, return
it directly from Buffer::insert and Buffer::replace. This fixes a
wrong behaviour where replacing at eof would lose the selected end
of line (as the implementation does not actually replace that end
of line)

1 files changed, 5 insertions, 3 deletions

diff --git a/src/buffer.hh b/src/buffer.hh
index 4f27e449..a2517956 100644
--- a/src/buffer.hh
+++ b/src/buffer.hh
@@ -7,6 +7,7 @@
 #include "enum.hh"
 #include "file.hh"
 #include "optional.hh"
+#include "range.hh"
 #include "safe_ptr.hh"
 #include "scope.hh"
 #include "shared_string.hh"
@@ -103,6 +104,7 @@ private:
 };
 
 using BufferLines = Vector<StringDataPtr, MemoryDomain::BufferContent>;
+using BufferRange = Range<BufferCoord>;
 
 // A Buffer is a in-memory representation of a file
 //
@@ -139,9 +141,9 @@ public:
     bool set_name(String name);
     void update_display_name();
 
-    BufferCoord insert(BufferCoord pos, StringView content);
+    BufferRange insert(BufferCoord pos, StringView content);
     BufferCoord erase(BufferCoord begin, BufferCoord end);
-    BufferCoord replace(BufferCoord begin, BufferCoord end, StringView content);
+    BufferRange replace(BufferCoord begin, BufferCoord end, StringView content);
 
     size_t          timestamp() const;
     void            set_fs_status(FsStatus);
@@ -231,7 +233,7 @@ public:
 private:
     void on_option_changed(const Option& option) override;
 
-    BufferCoord do_insert(BufferCoord pos, StringView content);
+    BufferRange do_insert(BufferCoord pos, StringView content);
     BufferCoord do_erase(BufferCoord begin, BufferCoord end);
 
     struct Modification;