diff options
| author | Johannes Altmanninger <aclopte@gmail.com> | 2024-09-18 16:52:50 +0200 |
|---|---|---|
| committer | Maxime Coste <mawww@kakoune.org> | 2024-09-18 20:52:44 +0100 |
| commit | 0e225db00efb33150e98e951de9a1b5c72971b12 (patch) | |
| tree | 45cbd7b43e0b7a277ef7e385bddfbf243e6fc902 /rc/tools | |
| parent | 4b71eedbae277d81720785e5f31d717ef9a409c5 (diff) | |
rc git: don't require client in git show-diff
This fails because the new logic wrongly assumes the presence of a client:
hook global WinCreate /.* 'git show-diff'
The "diff" process hangs because we never write to ${kak_response_fifo}.
After a "pkill diff", the *debug* buffer shows
error while waiting for shell: 1:1: 'evaluate-commands': 3:13: 'execute-keys': no such client: '-draft'
shell stderr: <<<
The client argument is completely unnecessary since we always want
to use the calling context's buffer anyway. Remove it.
Note that we can probably further simplify this by using "write"
instead of a shell process. I'll send that patch along a few other
error handling improvements later.
Closes #5235
Diffstat (limited to 'rc/tools')
| -rw-r--r-- | rc/tools/git.kak | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rc/tools/git.kak b/rc/tools/git.kak index 4277a06d..cf2f7319 100644 --- a/rc/tools/git.kak +++ b/rc/tools/git.kak @@ -196,7 +196,7 @@ define-command -params 1.. \ buffile_relative=${kak_buffile#"$(git rev-parse --show-toplevel)/"} echo >${kak_command_fifo} "evaluate-commands -save-regs | %{ set-register | %{ cat >${kak_response_fifo} } - execute-keys -client ${kak_client} -draft %{%<a-|><ret>} + execute-keys -draft %{%<a-|><ret>} }" git show "$rev:${buffile_relative}" | diff - ${kak_response_fifo} "$@" | |
