Avoid calling memcpy from empty string views

ubsan is unhappy when passing a nullptr as the source pointer to
memcpy even if the length is 0.

Fixes #4720

1 files changed, 2 insertions, 0 deletions

diff --git a/src/shared_string.cc b/src/shared_string.cc
index d76e0ac3..752ac828 100644
--- a/src/shared_string.cc
+++ b/src/shared_string.cc
@@ -16,6 +16,8 @@ StringDataPtr StringData::create(ArrayView<const StringView> strs)
     auto* data = reinterpret_cast<char*>(res + 1);
     for (auto& str : strs)
     {
+        if (str.length() == 0) // memccpy(..., nullptr, 0) is UB
+            continue;
         memcpy(data, str.begin(), (size_t)str.length());
         data += (int)str.length();
     }