summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxime Coste <frrrwww@gmail.com>2012-06-25 19:11:13 +0200
committerMaxime Coste <frrrwww@gmail.com>2012-06-25 19:11:13 +0200
commitcffb895797998f18bbf80c1f1e67c44f511c51cf (patch)
tree39106dab298cdc94362bd9692f7e61225cb3eced
parentccec35f88cf58f61d08dc4aa8801aa8b2f5b75de (diff)
remove ugly id_to_str param in idvaluemap and str_to_str
-rw-r--r--src/filter_group.cc4
-rw-r--r--src/filter_registry.cc2
-rw-r--r--src/highlighter_group.cc4
-rw-r--r--src/highlighter_registry.cc2
-rw-r--r--src/idvaluemap.hh8
-rw-r--r--src/utils.hh5
6 files changed, 9 insertions, 16 deletions
diff --git a/src/filter_group.cc b/src/filter_group.cc
index bf5839ac..2dfe0684 100644
--- a/src/filter_group.cc
+++ b/src/filter_group.cc
@@ -41,13 +41,13 @@ FilterGroup& FilterGroup::get_group(const String& id)
CandidateList FilterGroup::complete_id(const String& prefix,
size_t cursor_pos)
{
- return m_filters.complete_id<str_to_str>(prefix, cursor_pos);
+ return m_filters.complete_id(prefix, cursor_pos);
}
CandidateList FilterGroup::complete_group_id(const String& prefix,
size_t cursor_pos)
{
- return m_filters.complete_id_if<str_to_str>(
+ return m_filters.complete_id_if(
prefix, cursor_pos,
[](std::pair<String, FilterFunc>& func)
{ return func.second.target<FilterGroup>() != nullptr; });
diff --git a/src/filter_registry.cc b/src/filter_registry.cc
index 3a54954f..a2a08266 100644
--- a/src/filter_registry.cc
+++ b/src/filter_registry.cc
@@ -33,7 +33,7 @@ void FilterRegistry::add_filter_to_group(FilterGroup& group,
CandidateList FilterRegistry::complete_filter(const String& prefix,
size_t cursor_pos)
{
- return m_factories.complete_id<str_to_str>(prefix, cursor_pos);
+ return m_factories.complete_id(prefix, cursor_pos);
}
}
diff --git a/src/highlighter_group.cc b/src/highlighter_group.cc
index 2c86c62f..5203f2a6 100644
--- a/src/highlighter_group.cc
+++ b/src/highlighter_group.cc
@@ -41,13 +41,13 @@ HighlighterGroup& HighlighterGroup::get_group(const String& id)
CandidateList HighlighterGroup::complete_id(const String& prefix,
size_t cursor_pos)
{
- return m_highlighters.complete_id<str_to_str>(prefix, cursor_pos);
+ return m_highlighters.complete_id(prefix, cursor_pos);
}
CandidateList HighlighterGroup::complete_group_id(const String& prefix,
size_t cursor_pos)
{
- return m_highlighters.complete_id_if<str_to_str>(
+ return m_highlighters.complete_id_if(
prefix, cursor_pos,
[](std::pair<String, HighlighterFunc>& func)
{ return func.second.target<HighlighterGroup>() != nullptr; });
diff --git a/src/highlighter_registry.cc b/src/highlighter_registry.cc
index bd0a57b7..b2ca4e97 100644
--- a/src/highlighter_registry.cc
+++ b/src/highlighter_registry.cc
@@ -35,7 +35,7 @@ void HighlighterRegistry::add_highlighter_to_group(Window& window,
CandidateList HighlighterRegistry::complete_highlighter(const String& prefix,
size_t cursor_pos)
{
- return m_factories.complete_id<str_to_str>(prefix, cursor_pos);
+ return m_factories.complete_id(prefix, cursor_pos);
}
}
diff --git a/src/idvaluemap.hh b/src/idvaluemap.hh
index a6eb315d..f6627872 100644
--- a/src/idvaluemap.hh
+++ b/src/idvaluemap.hh
@@ -63,8 +63,7 @@ public:
}
}
- template<String (*id_to_string)(const _Id&),
- typename _Condition>
+ template<typename _Condition>
CandidateList complete_id_if(const String& prefix,
size_t cursor_pos,
_Condition condition)
@@ -76,18 +75,17 @@ public:
if (not condition(value))
continue;
- String id_str = id_to_string(value.first);
+ String id_str = value.first;
if (id_str.substr(0, real_prefix.length()) == real_prefix)
result.push_back(std::move(id_str));
}
return result;
}
- template<String (*id_to_string)(const _Id&)>
CandidateList complete_id(const String& prefix,
size_t cursor_pos)
{
- return complete_id_if<id_to_string>(
+ return complete_id_if(
prefix, cursor_pos, [](const value_type&) { return true; });
}
diff --git a/src/utils.hh b/src/utils.hh
index ebde984f..e6d37cb8 100644
--- a/src/utils.hh
+++ b/src/utils.hh
@@ -117,11 +117,6 @@ bool operator== (const std::unique_ptr<T>& lhs, T* rhs)
return lhs.get() == rhs;
}
-inline String str_to_str(const String& str)
-{
- return str;
-}
-
}
#endif // utils_hh_INCLUDED