summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxime Coste <frrrwww@gmail.com>2016-07-11 19:40:22 +0100
committerMaxime Coste <frrrwww@gmail.com>2016-07-11 19:44:29 +0100
commitbb688cf42d4e4d2fb78419f0824714145490afa3 (patch)
treed56ac51b371d644373ded8c3a012c3f96aade892
parent530ecf212eedce7ae62c185873ae42033eeee925 (diff)
Do not throw when recursive hook calls are detected
Running hooks is non critical, and should never `fail` as far as caller is concerned.
-rw-r--r--src/hook_manager.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/hook_manager.cc b/src/hook_manager.cc
index bd83b976..30f90ae3 100644
--- a/src/hook_manager.cc
+++ b/src/hook_manager.cc
@@ -53,9 +53,9 @@ void HookManager::run_hook(StringView hook_name,
if (contains(m_running_hooks, std::make_pair(hook_name, param)))
{
- auto error = format("recursive call of hook {}/{}, aborting", hook_name, param);
+ auto error = format("recursive call of hook {}/{}, not executing", hook_name, param);
write_to_debug_buffer(error);
- throw runtime_error(std::move(error));
+ return;
}
m_running_hooks.emplace_back(hook_name, param);