| Age | Commit message (Collapse) | Author |
|
Signed-off-by: amolmote <amolmote201@gmail.com>
|
|
|
|
|
|
|
|
contributor-cheatsheet
- adding documentation increases awareness that this label exists and can help PRs get merged quicker
- Manual squash causes removal of lgtm label and re-run of CI tests.
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
|
|
For the more compulsive among us, let's have a space just before a sentence begins.
|
|
* Deduplify content: Remove reviewee content from the review-guidelines,
reorganize pull request page.
Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
* Reformat ToC headers, move KISS section higher
Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
|
|
|
|
* feat: Adding guidance on commit message style
* Update commit message guidelines
* Add notes on kind/area
Co-authored-by: Bob Killen <bob.killen@linux.com>
|
|
* Improve squashing documentation
Signed-off-by: Celeste Horgan <celeste@cncf.io>
* Apply suggestions from code review
Co-Authored-By: Bob Killen <killen.bob@gmail.com>
* Update contributors/guide/github-workflow.md
Co-Authored-By: Bob Killen <killen.bob@gmail.com>
Co-authored-by: Bob Killen <killen.bob@gmail.com>
|
|
|
|
|
|
|
|
|
|
Signed-Off-By: Daniel Lipovestky <daniel@platform9.com>
Co-Authored-By: Christoph Blecker <admin@toph.ca>
|
|
* Reviewd and updated spelling, grammar and punctuation.
* Update contributors/guide/pull-requests.md
Co-Authored-By: Christoph Blecker <admin@toph.ca>
* Update contributors/guide/pull-requests.md
Co-Authored-By: Christoph Blecker <admin@toph.ca>
|
|
Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
|
|
|
|
|
|
updated
|
|
Clarify the use of lgtm and approve labels, and call out special
cases which may result in surprising behavior by the code review
system.
|
|
|
|
The SIG-Release ephemera on issue workflow is moved to the devel guide.
Updating reference to it.
Signed-off-by: Tim Pepper <tpepper@vmware.com>
|
|
Added the text from #1628 under 'Best Practices for Faster Reviews' and linked it at the top of the document.
Issue: #1628
|
|
|
|
|
|
Minor cleanup in pull-requests.md
|
|
Pinging someone with a github mention is different from using a bot command to assign them as a reviewer. This commit includes a specific explanation.
|
|
This addresses a few broken links that resulted from style changes.
|
|
The pull-requests.md document has gotten quite out of date. This commit
does a massive scrub of its content for completeness, accuracy and
readability. A number of links are fixed, updated information on labels
and bot commands is added, workflow descriptions for test and merge are
updated, and a description of the KEP process is added.
|
|
Understanding the pull request process is central to being a successful
contributor. This commit moves it from the more technical k8s internals
detailed devel/ area over to the guide/ where it will get more
visibility.
This patch just moves the file and leaves a tombstone reminder
behind.
|