summaryrefslogtreecommitdiff
path: root/contributors/guide/pull-requests.md
AgeCommit message (Collapse)Author
2022-09-11updated contributors/guide/pull-requests.mdamolmote
Signed-off-by: amolmote <amolmote201@gmail.com>
2021-10-27Remove bold formattingAvinash Upadhyaya K R
2021-10-26Reword github keywords usage in PR and commit messagesAvinash Upadhyaya K R
2021-06-22Typos and other punctuation fixesPushkar Joglekar
2021-05-13Add documentaion for tide/squash-on-merge to pull-request.md and ↵Madhav Jivrajani
contributor-cheatsheet - adding documentation increases awareness that this label exists and can help PRs get merged quicker - Manual squash causes removal of lgtm label and re-run of CI tests. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2020-11-19tiny whitespace fixDan Kenigsberg
For the more compulsive among us, let's have a space just before a sentence begins.
2020-08-17Deduplify content: Remove reviewee content from the review-guidelines (#5031)Jorge O. Castro
* Deduplify content: Remove reviewee content from the review-guidelines, reorganize pull request page. Signed-off-by: Jorge O. Castro <jorgec@vmware.com> * Reformat ToC headers, move KISS section higher Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
2020-06-19Add frontmatter descriptions to the contributor guide docsBob Killen
2020-06-04feat: Adding guidance on commit message style (#4343)vishakha
* feat: Adding guidance on commit message style * Update commit message guidelines * Add notes on kind/area Co-authored-by: Bob Killen <bob.killen@linux.com>
2020-04-06Improve squashing documentation (#4668)Celeste Horgan
* Improve squashing documentation Signed-off-by: Celeste Horgan <celeste@cncf.io> * Apply suggestions from code review Co-Authored-By: Bob Killen <killen.bob@gmail.com> * Update contributors/guide/github-workflow.md Co-Authored-By: Bob Killen <killen.bob@gmail.com> Co-authored-by: Bob Killen <killen.bob@gmail.com>
2020-02-10Assigning weights to contributor documents for proper surfacingvishakha
2019-12-24feat: Documentation about ok-to-test labelvishakha
2019-10-16contributor-guide: add note about #pr-reviews channelNikhita Raghunath
2019-10-08Update contributor guide formatting to be Hugo compatible.Bob Killen
2019-08-05Fix broken link from PR guide to KEP process guideDaniel Lipovetsky
Signed-Off-By: Daniel Lipovestky <daniel@platform9.com> Co-Authored-By: Christoph Blecker <admin@toph.ca>
2019-06-21Reviewd and updated spelling, grammar and punctuation. (#3826)cryptographicfool
* Reviewd and updated spelling, grammar and punctuation. * Update contributors/guide/pull-requests.md Co-Authored-By: Christoph Blecker <admin@toph.ca> * Update contributors/guide/pull-requests.md Co-Authored-By: Christoph Blecker <admin@toph.ca>
2019-06-04Add hugo metadata to the contributor guidesJorge O. Castro
Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
2019-05-07change old link to new linktoyoda
2019-02-06all URL pointing to kubectl-conventions.md have been fixededuartua
2019-01-29file release.md has been moved to /devel/sig-release - URLs in k/community ↵eduartua
updated
2018-10-24Clarify the use of lgtm and approve labelsChris Hoge
Clarify the use of lgtm and approve labels, and call out special cases which may result in surprising behavior by the code review system.
2018-10-06Replace submit queue with Tide in docsNikhita Raghunath
2018-08-30contrib guide: update linkTim Pepper
The SIG-Release ephemera on issue workflow is moved to the devel guide. Updating reference to it. Signed-off-by: Tim Pepper <tpepper@vmware.com>
2018-08-26Adds the 'trivial edit contribution policy'Tobias Nehrlich
Added the text from #1628 under 'Best Practices for Faster Reviews' and linked it at the top of the document. Issue: #1628
2018-07-30add section on prs being held up by release cycleJeffrey Sica
2018-03-15Change k8s-merge-robot to k8s-ci-robotbin liu
2018-02-22Release Notes: Title added; minor cleanup. Faster reviews tombstone added. ↵guineveresaenger
Minor cleanup in pull-requests.md
2018-02-22Explains how to assign a reviewer using a bot commandguineveresaenger
Pinging someone with a github mention is different from using a bot command to assign them as a reviewer. This commit includes a specific explanation.
2018-02-22Fixes table, capitalization, and in-doc linksguineveresaenger
This addresses a few broken links that resulted from style changes.
2018-02-19Major rewrite of pull request processguineveresaenger
The pull-requests.md document has gotten quite out of date. This commit does a massive scrub of its content for completeness, accuracy and readability. A number of links are fixed, updated information on labels and bot commands is added, workflow descriptions for test and merge are updated, and a description of the KEP process is added.
2018-02-19contrib guide: move pull-requests.md from devel/ to guide/guineveresaenger
Understanding the pull request process is central to being a successful contributor. This commit moves it from the more technical k8s internals detailed devel/ area over to the guide/ where it will get more visibility. This patch just moves the file and leaves a tombstone reminder behind.