summaryrefslogtreecommitdiff
path: root/contributors
diff options
context:
space:
mode:
authorDhruv Maindola <maindola.dhruv@gmail.com>2022-11-22 03:06:14 +0530
committerGitHub <noreply@github.com>2022-11-21 13:36:14 -0800
commitba3160d44f9e590f66a8460d35dd01f9426ee496 (patch)
tree9c32bfb7cde42d2ce10b67d2c0b29bc0290e1584 /contributors
parentd5677929a3e201f1c58598730cc73c4df22fdfc9 (diff)
Fixed inconsistent first character capitalization. (#6778)
* Fixed inconsistent first character capitalization. In some bullet points there were words where first character wasn't in uppercase and in some they were. Fixed the inconsistency. * Update contributing.md
Diffstat (limited to 'contributors')
-rw-r--r--contributors/guide/contributing.md14
1 files changed, 7 insertions, 7 deletions
diff --git a/contributors/guide/contributing.md b/contributors/guide/contributing.md
index 5ea85606..dfc004ba 100644
--- a/contributors/guide/contributing.md
+++ b/contributors/guide/contributing.md
@@ -60,9 +60,9 @@ Refer to its [command reference documentation](https://go.k8s.io/bot-commands).
Common new contributor PR issues are:
-* not having correctly signed the CLA ahead of your first PR. See the [CLA page](/CLA.md) for troubleshooting help, in some cases you might need to file a ticket with the CNCF to resolve a CLA problem.
-* finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](first-contribution.md#learn-about-sigs) section)
-* dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](/contributors/devel/sig-testing/flaky-tests.md))
+* Not having correctly signed the CLA ahead of your first PR. See the [CLA page](/CLA.md) for troubleshooting help, in some cases you might need to file a ticket with the CNCF to resolve a CLA problem.
+* Finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](first-contribution.md#learn-about-sigs) section)
+* Dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](/contributors/devel/sig-testing/flaky-tests.md))
* Not following [scalability good practices](scalability-good-practices.md)
* Include mentions (like @person) and [keywords](https://help.github.com/en/articles/closing-issues-using-keywords) which could close the issue (like fixes #xxxx) in commit messages.
@@ -73,10 +73,10 @@ There are two aspects of code review: giving and receiving.
To make it easier for your PR to receive reviews, consider the reviewers will need you to:
-* follow the project [coding conventions](coding-conventions.md)
-* write [good commit messages](https://chris.beams.io/posts/git-commit/)
-* break large changes into a logical series of smaller patches which individually make easily understandable changes, and in aggregate solve a broader issue
-* label PRs with appropriate SIGs and reviewers: to do this read the messages the bot sends you to guide you through the PR process
+* Follow the project [coding conventions](coding-conventions.md)
+* Write [good commit messages](https://chris.beams.io/posts/git-commit/)
+* Break large changes into a logical series of smaller patches which individually make easily understandable changes, and in aggregate solve a broader issue
+* Label PRs with appropriate SIGs and reviewers: to do this read the messages the bot sends you to guide you through the PR process
Reviewers, the people giving the review, are highly encouraged to revisit the [Code of Conduct](/code-of-conduct.md) as well as [community expectations](./expectations.md#expectations-of-reviewers-review-latency) and must go above and beyond to promote a collaborative, respectful community.
When reviewing PRs from others [The Gentle Art of Patch Review](http://sage.thesharps.us/2014/09/01/the-gentle-art-of-patch-review/) suggests an iterative series of focuses which is designed to lead new contributors to positive collaboration without inundating them initially with nuances: