diff options
| author | Maria Ntalla <mntalla@pivotal.io> | 2019-02-21 11:54:00 +0000 |
|---|---|---|
| committer | Maria Ntalla <mntalla@pivotal.io> | 2019-02-21 11:54:00 +0000 |
| commit | 034d4f60730ceb92eb3c4447d6137766a84024ac (patch) | |
| tree | b47ffdf0f67645c22a359f1e74fd158ab48eee5b /contributors | |
| parent | f87e0f084c2636a8ba8ed8674faa25b59087c533 (diff) | |
Add prow link, detail SIG contact
Diffstat (limited to 'contributors')
| -rw-r--r-- | contributors/devel/sig-testing/testing.md | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/contributors/devel/sig-testing/testing.md b/contributors/devel/sig-testing/testing.md index fd9d9427..d5b415ba 100644 --- a/contributors/devel/sig-testing/testing.md +++ b/contributors/devel/sig-testing/testing.md @@ -198,10 +198,10 @@ Please refer to [Integration Testing in Kubernetes](integration-tests.md). Please refer to [End-to-End Testing in Kubernetes](e2e-tests.md). -## Running your contribution in the Kubernetes CI -Once you open a PR, [`prow`][prow-doc] runs pre-submit tests in CI. +## Running your contribution through Kubernetes CI/CD +Once you open a PR, [`prow`][prow-url] runs pre-submit tests in CI. You can find more about `prow` in [kubernetes/test-infra][prow-git] and in [this blog post][prow-doc] on automation involved in testing PRs to Kubernetes. -If you are not a [Kubernetes org member][member], another org member will need to run [`/ok-to-test`][ok-to-test] on your PR. +If you are not a [Kubernetes org member][membership], another org member will need to run [`/ok-to-test`][ok-to-test] on your PR. Find out more about [other commands][prow-cmds] you can use to interact with prow through GitHub comments. @@ -214,13 +214,16 @@ If the failure seems unrelated to the change you're submitting: - If not, open a new one (like [this example][new-issue-example]) and [label it `kind/flake`][kind/flake] - Run [`/retest`][retest] on your PR to re-trigger the tests -- Is it a failure that shouldn't be happening (in other words, is the test now wrong) - - Get in touch with the SIG - - preferably as a comment on your PR, by tagging the [team][k-teams] (for example a [reviewers team for the SIG][k-teams-review]) - - if you don't get a response in 24h, engage with the SIG on their channel on the Kubernetes slack and/or attend one of the [SIG meetings][sig-meetings] to ask for input. +- Is it a failure that shouldn't be happening (in other words, is the test expectation now wrong) + - Get in touch with the SIG that your PR is labeled after + - preferably as a comment on your PR, by tagging the [github team][k-teams] (for example a [reviewers team for the SIG][k-teams-review]) + - write your reasoning as to why you think the test is now outdated and should be changed + - if you don't get a response in 24 hours, engage with the SIG on their channel on the [Kubernetes slack](http://slack.k8s.io/) and/or attend one of the [SIG meetings][sig-meetings] to ask for input. +[prow-url]: https://prow.k8s.io +[prow-git]: https://git.k8s.io/test-infra/prow [prow-doc]: https://kubernetes.io/blog/2018/08/29/the-machines-can-do-the-work-a-story-of-kubernetes-testing-ci-and-automating-the-contributor-experience/#enter-prow -[member]: https://github.com/kubernetes/community/blob/master/community-membership.md#member +[membership]: https://github.com/kubernetes/community/blob/master/community-membership.md#member [k-teams]: https://github.com/orgs/kubernetes/teams [k-teams-review]: https://github.com/orgs/kubernetes/teams?utf8=%E2%9C%93&query=review [ok-to-test]: https://prow.k8s.io/command-help#ok_to_test |