summaryrefslogtreecommitdiff
path: root/contributors/guide
diff options
context:
space:
mode:
authork8s-ci-robot <k8s-ci-robot@users.noreply.github.com>2018-10-08 11:32:01 -0700
committerGitHub <noreply@github.com>2018-10-08 11:32:01 -0700
commitf1e2ffa66289528ce0ccc61efc07b7623456bdee (patch)
tree82135d256d8c12b88a55d3d7c934f67e1e60d1ea /contributors/guide
parentea9d3092d9921de061603c155e51a98ca954a4f4 (diff)
parentc2bd5cb83977863e15c1c56d692f8f3687cccc1c (diff)
Merge pull request #2701 from nikhita/replace-submit-queue-with-tide
Replace submit queue with Tide in docs
Diffstat (limited to 'contributors/guide')
-rw-r--r--contributors/guide/contributor-cheatsheet.md4
-rw-r--r--contributors/guide/owners.md24
-rw-r--r--contributors/guide/pull-requests.md20
3 files changed, 22 insertions, 26 deletions
diff --git a/contributors/guide/contributor-cheatsheet.md b/contributors/guide/contributor-cheatsheet.md
index af36f354..696e59e6 100644
--- a/contributors/guide/contributor-cheatsheet.md
+++ b/contributors/guide/contributor-cheatsheet.md
@@ -15,12 +15,12 @@ A list of common resources when contributing to Kubernetes.
## Workflow
- [Gubernator Dashboard - k8s.reviews](https://k8s-gubernator.appspot.com/pr)
-- [Submit Queue](https://submit-queue.k8s.io)
+- [Tide](https://prow.k8s.io/tide)
- [Bot commands](https://go.k8s.io/bot-commands)
- [GitHub labels](https://go.k8s.io/github-labels)
- [Release Buckets](https://gcsweb.k8s.io/gcs/kubernetes-release/)
- Developer Guide
- - [Cherry Picking Guide](/contributors/devel/cherry-picks.md) - [Queue](https://cherrypick.k8s.io/#/queue)
+ - [Cherry Picking Guide](/contributors/devel/cherry-picks.md)
- [Kubernetes Code Search](https://cs.k8s.io/), maintained by [@dims](https://github.com/dims)
diff --git a/contributors/guide/owners.md b/contributors/guide/owners.md
index 021d28e8..1a3bf457 100644
--- a/contributors/guide/owners.md
+++ b/contributors/guide/owners.md
@@ -209,21 +209,15 @@ is the state of today.
## Automation using OWNERS files
-### ~[`mungegithub`](https://git.k8s.io/test-infra/mungegithub)~ is deprecated
-
-Mungegithub's blunderbuss and submit-queue mungers are currently used for kubernetes/kubernetes. Their
-equivalents are the prow blunderbuss plugin, and prow's tide cmd. These docs will be removed once
-kubernetes/kubernetes has transitioned over to tide.
-
-~Mungegithub polls GitHub, and "munges" things it finds, including issues and pull requests. It is
-stateful, in that restarting it means it loses track of which things it has munged at what time.~
-
-- ~[munger:
- blunderbuss](https://git.k8s.io/test-infra/mungegithub/mungers/blunderbuss.go)~
- - ~responsible for determining **reviewers** and assigning to them~
-- [munger:
- submit-queue](https://git.k8s.io/test-infra/mungegithub/mungers/submit-queue.go)
- - responsible for merging PR's
+Kubernetes uses the Prow Blunderbuss plugin and Tide.
+Tide uses GitHub queries to select PRs into “tide pools”, runs as many in a
+batch as it can (“tide comes in”), and merges them (“tide goes out”).
+
+- [Blunderbuss plugin](https://git.k8s.io/test-infra/prow/plugins/blunderbuss):
+ - responsible for determining **reviewers**
+- [Tide](https://git.k8s.io/test-infra/prow/cmd/tide):
+ - responsible for automatically running batch tests and merging multiple PRs together whenever possible.
+ - responsible for retriggering stale PR tests.
- responsible for updating a GitHub status check explaining why a PR can't be merged (eg: a
missing `lgtm` or `approved` label)
diff --git a/contributors/guide/pull-requests.md b/contributors/guide/pull-requests.md
index 673901ed..b94dc2a0 100644
--- a/contributors/guide/pull-requests.md
+++ b/contributors/guide/pull-requests.md
@@ -72,7 +72,7 @@ Here's the process the pull request goes through on its way from submission to m
1. If you're **not** a member of the Kubernetes organization, a Reviewer/Kubernetes Member checks that the pull request is safe to test. If so, they comment `/ok-to-test`. Pull requests by Kubernetes organization [members](/community-membership.md) do not need this step. Now the pull request is considered to be trusted, and the pre-submit tests will run:
- 1. Automatic tests run. See the current list of tests on the [MERGE REQUIREMENTS tab, at this link](https://submit-queue.k8s.io/#/info)
+ 1. Automatic tests run. See the current list of tests at this [link](https://prow.k8s.io/?repo=kubernetes%2Fkubernetes&type=presubmit)
1. If tests fail, resolve issues by pushing edits to your pull request branch
1. If the failure is a flake, anyone on trusted pull requests can comment `/retest` to rerun failed tests
@@ -82,24 +82,26 @@ Here's the process the pull request goes through on its way from submission to m
1. (Optional) Some reviewers prefer that you squash commits at this step
1. Follow the bot suggestions to assign an OWNER who will add the `/approve` label to the pull request
-Once the tests pass, all failures are commented as flakes, or the reviewer adds the labels `/lgtm` and `/approved`, the pull request enters the final merge queue. The merge queue is needed to make sure no incompatible changes have been introduced by other pull requests since the tests were last run on your pull request.
+Once the tests pass and the reviewer adds the `lgtm` and `approved` labels, the pull request enters the final merge pool. The merge pool is needed to make sure no incompatible changes have been introduced by other pull requests since the tests were last run on your pull request.
<!-- TODO: create parallel instructions for reviewers -->
-The [GitHub "munger"](https://git.k8s.io/test-infra/mungegithub) submit-queue plugin will manage the merge queue automatically.
+[Tide](https://git.k8s.io/test-infra/prow/cmd/tide) will manage the merge pool
+automatically. It uses GitHub queries to select PRs into “tide pools”,
+runs as many in a batch as it can (“tide comes in”), and merges them (“tide goes out”).
-1. The pull request enters the merge queue ([http://submit-queue.k8s.io](http://submit-queue.k8s.io))
-1. The merge queue triggers a test re-run with the comment `/test all [submit-queue is verifying that this pull request is safe to merge]`
- 1. Author has signed the CLA (`cncf-cla: yes` label added to pull request)
- 1. No changes made since last `lgtm` label applied
+1. The pull request enters the [merge pool](https://prow.k8s.io/tide)
+if the merge criteria are met. The [PR dashboard](https://prow.k8s.io/pr) shows
+the difference between your PR's state and the merge criteria so that you can
+easily see all criteria that are not being met and address them.
1. If tests fail, resolve issues by pushing edits to your pull request branch
1. If the failure is a flake, anyone can comment `/retest` if the pull request is trusted
-1. If tests pass, the merge queue automatically merges the pull request
+1. If tests pass, Tide automatically merges the pull request
That's the last step. Your pull request is now merged.
## Marking Unfinished Pull Requests
-If you want to solicit reviews before the implementation of your pull request is complete, you should hold your pull request to ensure that the merge queue does not pick it up and attempt to merge it. There are two methods to achieve this:
+If you want to solicit reviews before the implementation of your pull request is complete, you should hold your pull request to ensure that Tide does not pick it up and attempt to merge it. There are two methods to achieve this:
1. You may add the `/hold` or `/hold cancel` comment commands
2. You may add or remove a `WIP` or `[WIP]` prefix to your pull request title