diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2019-01-15 18:23:03 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-01-15 18:23:03 -0800 |
| commit | 06ff392d1876b39901acaf3303ba54a7790cc2ea (patch) | |
| tree | d6df9967b004bb2c03b7f846a1c6e3f6284a4aff /contributors/devel | |
| parent | acf6259d43c1e4ff72f1c21bd6698ad8e397042e (diff) | |
| parent | a156dd10349effb8948169066b639e5a001fb5a1 (diff) | |
Merge pull request #3099 from eduartua/issue-3064-2
File moved (k/community/contributors/devel/collab.md) - Created tombstone file and updated URL in other files
Diffstat (limited to 'contributors/devel')
| -rw-r--r-- | contributors/devel/collab.md | 36 |
1 files changed, 2 insertions, 34 deletions
diff --git a/contributors/devel/collab.md b/contributors/devel/collab.md index 73ddebb9..62cb85eb 100644 --- a/contributors/devel/collab.md +++ b/contributors/devel/collab.md @@ -1,35 +1,3 @@ -# On Collaborative Development +This document has moved to: [here](https://git.k8s.io/community/contributors/guide/collab.md). -## Code reviews - -All changes must be code reviewed. For non-maintainers this is obvious, since -you can't commit anyway. But even for maintainers, we want all changes to get at -least one review, preferably (for non-trivial changes obligatorily) from someone -who knows the areas the change touches. For non-trivial changes we may want two -reviewers. The primary reviewer will make this decision and nominate a second -reviewer, if needed. Except for trivial changes, PRs should not be committed -until relevant parties (e.g. owners of the subsystem affected by the PR) have -had a reasonable chance to look at PR in their local business hours. - -Most PRs will find reviewers organically. If a maintainer intends to be the -primary reviewer of a PR they should set themselves as the assignee on GitHub -and say so in a reply to the PR. Only the primary reviewer of a change should -actually do the merge, except in rare cases (e.g. they are unavailable in a -reasonable timeframe). - -If a PR has gone 2 work days without an owner emerging, please poke the PR -thread and ask for a reviewer to be assigned. - -Except for rare cases, such as trivial changes (e.g. typos, comments) or -emergencies (e.g. broken builds), maintainers should not merge their own -changes. - -Expect reviewers to request that you avoid [common go style -mistakes](https://github.com/golang/go/wiki/CodeReviewComments) in your PRs. - -## Assigned reviews - -Maintainers can assign reviews to other maintainers, when appropriate. The -assignee becomes the shepherd for that PR and is responsible for merging the PR -once they are satisfied with it or else closing it. The assignee might request -reviews from non-maintainers. +*This file is a redirect stub. It should be deleted within 3 months from the current date.*
\ No newline at end of file |