diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2022-06-10 11:39:12 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-10 11:39:12 -0700 |
| commit | 5bbd49d248cdcc04b41d56e18d9f6d5772359087 (patch) | |
| tree | 64a26e4e801d58f473e93e1aaf31b595dd264f0a /communication | |
| parent | 69e265a15e709f5256cb817a49949dd5116a6f38 (diff) | |
| parent | 1630383af8a7d9f212f730a3706667a23ab5ed7c (diff) | |
Merge pull request #6682 from markyjackson-taulia/master
[Issues 6606] Add updated slack-guidelines for moderators
Diffstat (limited to 'communication')
| -rw-r--r-- | communication/slack-guidelines.md | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/communication/slack-guidelines.md b/communication/slack-guidelines.md index 869dc2c4..a9f6afa4 100644 --- a/communication/slack-guidelines.md +++ b/communication/slack-guidelines.md @@ -162,8 +162,10 @@ To add a channel, open a Pull Request (PR) updating the [slack-config][]. - Special accommodations will be made where necessary. After you submit your request the Slack Admins will review and follow-up with -any questions in the PR itself. Once it is signed off and merged, the channel -will be created. +any questions in the PR itself. +There are two approvals needed. `/lgtm` and `/approve`. Once one moderator give the `/lgtm`, a hold will be placed on the PR using `/hold`. This hold will remain in place until one or more moderators reviews +and add the `/approve` command as well as `/hold cancel`, which will remove the hold on the PR. +Once it is signed off and merged, the channel will be created. For further information, see the [Slack Config Documentation][]. |