summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authork8s-ci-robot <k8s-ci-robot@users.noreply.github.com>2018-10-01 14:22:16 -0700
committerGitHub <noreply@github.com>2018-10-01 14:22:16 -0700
commitf70574f8ab1100830bd661be4c91a2efe14479a5 (patch)
tree70f97ee731eb4282f91a7e41f9f99543cb21dae7
parentb8861a4a84b053d359508d7e6afb85bfb52654c0 (diff)
parent0f6ab1967735fe8164816f03c2ccae1753979186 (diff)
Merge pull request #2489 from tallclair/runtime-class
Mark RuntimeClass as implementable
-rw-r--r--keps/sig-node/0014-runtime-class.md16
1 files changed, 9 insertions, 7 deletions
diff --git a/keps/sig-node/0014-runtime-class.md b/keps/sig-node/0014-runtime-class.md
index 0dff017c..1d1cac28 100644
--- a/keps/sig-node/0014-runtime-class.md
+++ b/keps/sig-node/0014-runtime-class.md
@@ -7,12 +7,14 @@ owning-sig: sig-node
participating-sigs:
- sig-architecture
reviewers:
- - TBD
+ - dchen1107
+ - derekwaynecarr
+ - yujuhong
approvers:
- - TBD
-editor: TBD
+ - dchen1107
+ - derekwaynecarr
creation-date: 2018-06-19
-status: provisional
+status: implementable
---
# Runtime Class
@@ -297,8 +299,8 @@ to beta.
The Kubelet uses an Informer to keep a local cache of all RuntimeClass objects. When a new pod is
added, the Kubelet resolves the Pod's RuntimeClass against the local RuntimeClass cache. Once
resolved, the RuntimeHandler field is passed to the CRI as part of the
-[`RunPodSandboxRequest`][]. At that point, the interpretation of the RuntimeHandler is left to the
-CRI implementation, but it should be cached if needed for subsequent calls.
+[`RunPodSandboxRequest`][runpodsandbox]. At that point, the interpretation of the RuntimeHandler is
+left to the CRI implementation, but it should be cached if needed for subsequent calls.
If the RuntimeClass cannot be resolved (e.g. doesn't exist) at Pod creation, then the request will
be rejected in admission (controller to be detailed in a following update). If the RuntimeClass
@@ -307,7 +309,7 @@ the Pod. The admission check on a replica recreation will prevent the scheduler
the `RuntimeHandler` is not recognized by the CRI implementation, then `RunPodSandbox` will return
an error.
-[RunPodSandboxRequest]: https://github.com/kubernetes/kubernetes/blob/b05a61e299777c2030fbcf27a396aff21b35f01b/pkg/kubelet/apis/cri/runtime/v1alpha2/api.proto#L344
+[runpodsandbox]: https://github.com/kubernetes/kubernetes/blob/b05a61e299777c2030fbcf27a396aff21b35f01b/pkg/kubelet/apis/cri/runtime/v1alpha2/api.proto#L344
### Risks and Mitigations