diff options
| author | mattjmcnaughton <mattjmcnaughton@gmail.com> | 2019-05-05 15:46:22 -0400 |
|---|---|---|
| committer | mattjmcnaughton <mattjmcnaughton@gmail.com> | 2019-05-05 15:46:22 -0400 |
| commit | f47fc3ee18b59cc37f8dbc7d5892703bcc96605d (patch) | |
| tree | ae4afa5cc08a72c33714ef3b7589af9b278b1ac2 | |
| parent | 5b12936b6a91ddca6b5aa36b015096a9694ef464 (diff) | |
Update cri-container-stats documentation
Update the cri-container-stats documentation with more recent status
info. Particularly, clarify that the option to consume CRI stats has
been implemented, and link to the code that determines the consumption
option.
| -rw-r--r-- | contributors/devel/sig-node/cri-container-stats.md | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/contributors/devel/sig-node/cri-container-stats.md b/contributors/devel/sig-node/cri-container-stats.md index c1176f05..78fa76b7 100644 --- a/contributors/devel/sig-node/cri-container-stats.md +++ b/contributors/devel/sig-node/cri-container-stats.md @@ -115,7 +115,10 @@ behind it.* ## Status -The container metrics calls are added to CRI in Kubernetes 1.7, but Kubelet does not -yet use it to gather metrics from the runtime. We plan to enable Kubelet to -optionally consume the container metrics from the API in 1.8. - +The container metrics calls were added to CRI in Kubernetes 1.7, but Kubelet did not +yet use it to gather metrics from the runtime. In Kubernetes 1.8, Kubelet was +given the option to [consume the container metrics using CRI +stats](https://github.com/kubernetes/kubernetes/pull/51557). See the +`pkg/kubelet/cadvisor.go#UsingLegacyCadvisorStats` +[function](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cadvisor/util.go#L73) +for more information on how Kubelet determines the proper metrics source. |