diff options
| author | Brian Grant <bgrant0607@users.noreply.github.com> | 2017-06-20 23:58:42 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-20 23:58:42 -0700 |
| commit | e0b101c18d229adcafd73ef6b3b4b8f5849e2cd7 (patch) | |
| tree | 01cc80d8d663e96fb24aa23a6e89c5b3a18520da | |
| parent | 6a99cd760f2278672179f082e2874e2c51b4ccb5 (diff) | |
| parent | 708cf330ec4171e3fb2c883fd3cb6351f93e4c09 (diff) | |
Merge pull request #730 from alexandercampbell/fix-broken-pre-commit-link
pull-requests.md: delete broken link to pre-commit instructions
| -rw-r--r-- | contributors/devel/pull-requests.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/contributors/devel/pull-requests.md b/contributors/devel/pull-requests.md index 524ec2df..e3c5abdd 100644 --- a/contributors/devel/pull-requests.md +++ b/contributors/devel/pull-requests.md @@ -36,9 +36,9 @@ This guide is for contributors who already have a PR to submit. If you're lookin ## Run Local Verifications -Run these local verifications before you submit your PR. +You can run these local verifications before you submit your PR to predict the +pass or fail of continuous integration. -* Enable, run, and pass the Kubernetes [pre-commit hook](development.md#define-a-pre-commit-hook) which checks your repo formatting (and more); note that you may want to add these when you're closer to the end of your project, as they take time to run every time you commit * Run and pass `make verify` (can take 30-40 minutes) * Run and pass `make test` * Run and pass `make test-integration` @@ -323,4 +323,4 @@ a bit of thought into how your work can be made easier to review. If you do thes <!-- BEGIN MUNGE: GENERATED_ANALYTICS --> []() -<!-- END MUNGE: GENERATED_ANALYTICS -->
\ No newline at end of file +<!-- END MUNGE: GENERATED_ANALYTICS --> |