diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2021-07-29 09:56:20 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-29 09:56:20 -0700 |
| commit | c7fffe8511350dbf5d16a08d45ef6b8510f4aefc (patch) | |
| tree | 415d758ab4ac6defb838015d1708ccafbbdfe3e4 | |
| parent | ebf05b5f5a2239f2e9de00835ac1083eee4eeb9b (diff) | |
| parent | c5df2e6a9e4fd29032679fdb0b2c5de35c67a803 (diff) | |
Merge pull request #5917 from logicalhan/guidelines
amend instrumentation cardinality guidelines to explicitly advise against using namespaces
| -rw-r--r-- | contributors/devel/sig-instrumentation/instrumentation.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contributors/devel/sig-instrumentation/instrumentation.md b/contributors/devel/sig-instrumentation/instrumentation.md index 15569f14..b8f38e2f 100644 --- a/contributors/devel/sig-instrumentation/instrumentation.md +++ b/contributors/devel/sig-instrumentation/instrumentation.md @@ -160,8 +160,8 @@ constantly create new ones, with new names. However, they have a reasonable upper bound for a given size of infrastructure they refer to and its typical frequency of changes. -In general, “external” labels like pod or node name do not belong in the -instrumentation itself. They are to be attached to metrics by the collecting +In general, “external” labels like pod name, node name (any object name), & namespace do not belong in the +instrumentation itself (the exception being kube-state-metrics). They are to be attached to metrics by the collecting system that has the external knowledge ([blog post](https://www.robustperception.io/target-labels-are-for-life-not-just-for-christmas/)). ## Normalization |