diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2019-10-16 10:29:29 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-16 10:29:29 -0700 |
| commit | c0210ab035ea1fb4cee3b1b8d2608e2b9e88f8f3 (patch) | |
| tree | 8cfe15399e94ae62a8fd8f38a6bce0601c0ab2ec | |
| parent | aad32861d0ffac2f0f1ff43f59e4b92c5c360328 (diff) | |
| parent | de5ad57f8c38b883951710bb786ed03bee97f2a1 (diff) | |
Merge pull request #4177 from nikhita/pr-reviews-slack
contributor-guide: add note about #pr-reviews channel
| -rw-r--r-- | contributors/guide/contributor-cheatsheet/README.md | 2 | ||||
| -rw-r--r-- | contributors/guide/pull-requests.md | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/contributors/guide/contributor-cheatsheet/README.md b/contributors/guide/contributor-cheatsheet/README.md index d5e2f460..b44e7a9b 100644 --- a/contributors/guide/contributor-cheatsheet/README.md +++ b/contributors/guide/contributor-cheatsheet/README.md @@ -218,6 +218,8 @@ other forms of work that would be stored within a git repository. till the `[WIP]` or hold is lifted. - If you have not had your PR reviewed, do not close and open a new PR with the same changes. Ping your reviewers in a comment with `@<github username>`. +- If your PR isn't getting enough attention, post a link to the PR in the + `#pr-reviews` channel on Slack to find additional reviewers. #### Example PR Description diff --git a/contributors/guide/pull-requests.md b/contributors/guide/pull-requests.md index c403c974..f676c1e3 100644 --- a/contributors/guide/pull-requests.md +++ b/contributors/guide/pull-requests.md @@ -172,6 +172,8 @@ things you can do to move the process along: * If you have fixed all the issues from a review, and you haven't heard back, you should ping the assignee on the comment stream with a "please take another look" (`PTAL`) or similar comment indicating that you are ready for another review. + * If you still don't hear back, post a link to the pull request in the `#pr-reviews` channel on Slack to find additional reviewers. + Read on to learn more about how to get faster reviews by following best practices. # Best Practices for Faster Reviews |