diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2021-04-12 01:25:59 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-12 01:25:59 -0700 |
| commit | be1754728a996b4bddf3747c39b7bcdcb4ddd902 (patch) | |
| tree | 72fd0c98a7e669d14741cbc14477162f661821e8 | |
| parent | 38dc147ebd3c2eb9acc358bc0d30d88e01bc7937 (diff) | |
| parent | 33f4ce62a51cdfe91458726dcf10ed2fc402af1d (diff) | |
Merge pull request #5706 from SergeyKanzhelev/patch-4
A note on CP reviews
| -rw-r--r-- | contributors/devel/sig-release/cherry-picks.md | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/contributors/devel/sig-release/cherry-picks.md b/contributors/devel/sig-release/cherry-picks.md index 43a68b10..1b95c933 100644 --- a/contributors/devel/sig-release/cherry-picks.md +++ b/contributors/devel/sig-release/cherry-picks.md @@ -121,6 +121,16 @@ pull requests on the `master` branch in that they: - Are by default expected to be `kind/bug` and `priority/critical-urgent`. +- The original change to the `master` branch is expected to be merged for + some time and no related CI failures or test flakiness must be discovered. + +- The easy way to compare changes from the original change and cherry-pick + is to compare PRs `.patch` files. To generate the patch from + PR, just add the `.patch` to PR url. For example, for PR #100972 in + kubernetes repositry, ptach can be downloaded following this URL: + + `https://github.com/kubernetes/kubernetes/pull/100972.patch` + - Milestones must be set on the PR reflecting the milestone for the target release branch (for example, milestone v1.11 for a cherry pick onto branch `release-1.11`). This is normally done for you by automation. |