diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2020-01-29 06:20:13 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-29 06:20:13 -0800 |
| commit | bc92c5c32b14c981ddf6035c42d1d46a21476e9d (patch) | |
| tree | a88dec1a11016f8ac9daaac496f462d9f072ac5c | |
| parent | 4201ad60095c34a0f1e170fb88e00821929ec860 (diff) | |
| parent | a7db669da4639f2612d0234ca01e9bcafccd45d7 (diff) | |
Merge pull request #4463 from nikhita/nmc-docs
Update docs for granting approval privileges to NMCs
| -rw-r--r-- | github-management/README.md | 2 | ||||
| -rw-r--r-- | github-management/new-membership-procedure.md | 14 |
2 files changed, 14 insertions, 2 deletions
diff --git a/github-management/README.md b/github-management/README.md index 1799bd82..af74257b 100644 --- a/github-management/README.md +++ b/github-management/README.md @@ -53,6 +53,8 @@ community members, guiding them through the [process](new-membership-procedure.md) to request membership to a Kubernetes GitHub organization. +They also have approval privileges for adding new members to the GitHub config. + Our current coordinators are: * Naeil Ezzoueidi (**[@nzoueidi](https://github.com/nzoueidi)**, Central European) * Stephen Augustus (**[@justaugustus](https://github.com/justaugustus)**, US Eastern) diff --git a/github-management/new-membership-procedure.md b/github-management/new-membership-procedure.md index ba33b76b..f48f1df0 100644 --- a/github-management/new-membership-procedure.md +++ b/github-management/new-membership-procedure.md @@ -92,9 +92,19 @@ resolving. One PR can be used to resolve multiple membership requests. 1. Add a note to the original membership request stating that a membership invite will be sent out once the PR has merged. -1. Wait for a member of the GitHub administration team to approve the PR for -merge. +1. Wait for another New Membership Coordinator or a member of the +GitHub administration team to lgtm the PR for merge. +## Approving New Membership Requests + +New Membership Coordinators and members of the GitHub administration team +have approval privileges for the GitHub config in the +[kubernetes/org] repo. + +New Membership Coordinators should ensure that they approve PRs that +_only_ update members. Approval for any other config changes (like +GitHub teams) should be delegated to the respective SIG/WG/UG leads +or the GitHub administration team. |