diff options
| author | Devan Carpenter <devan@ii.coop> | 2019-10-16 13:22:27 -0700 |
|---|---|---|
| committer | Devan Carpenter <devan@ii.coop> | 2019-10-16 13:22:27 -0700 |
| commit | af108e4f6e1c819992843e4c8dde06ffb52d5e70 (patch) | |
| tree | ea1c3af2d0ebb3080c44305efc9cce38ec787a09 | |
| parent | 76f7827eda330c06ac09191af7a244d3203e2ff5 (diff) | |
Contributor Testing Guide: Update punctuation and grammar
| -rw-r--r-- | contributors/devel/sig-testing/testing.md | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/contributors/devel/sig-testing/testing.md b/contributors/devel/sig-testing/testing.md index 64b4935b..99f7ba89 100644 --- a/contributors/devel/sig-testing/testing.md +++ b/contributors/devel/sig-testing/testing.md @@ -25,9 +25,6 @@ passed both unit and integration tests. Kubernetes only merges pull requests when unit, integration, and e2e tests are passing, so it is often a good idea to make sure the e2e tests work as well. - - - ## Unit tests * Unit tests should be fully hermetic @@ -279,13 +276,13 @@ It is useful as a way to: All new PRs for tests should attempt to follow these steps in order to help enable a smooth review process: -1. The problem statement should be well defined. (Describe clearly the intended -purpose of the test, and why it is needed.) +1. The problem statement should clearly describe the intended purpose of the +test and why it is needed. -2. Get some agreement on how to design test from relevant SIG. +2. Get some agreement on how to design your test from the relevant SIG. 3. Create the PR. -4. Raise awareness of your PR to respective communities. (eg. via mailing lists, -Slack channels, Github mentions) +4. Raise awareness of your PR to respective communities (eg. via mailing lists, +Slack channels, Github mentions). |