diff options
| author | Kubernetes Submit Queue <k8s-merge-robot@users.noreply.github.com> | 2017-10-30 01:07:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-30 01:07:44 -0700 |
| commit | a0d81523e35af4a29843e0410d53fe35ef0fde6b (patch) | |
| tree | dff10c3a2ee75ab5cfdaf387138bc7f30d139298 | |
| parent | 28d88b385d6710d19063f90b836202bbb8ce4fbf (diff) | |
| parent | 7e448cbe6abeec434a8003e46e5f025177d665de (diff) | |
Merge pull request #1295 from gin419/patch-1
Automatic merge from submit-queue.
Update cloudprovider-storage-metrics.md fix wrong words
| -rw-r--r-- | contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md b/contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md index 2bfe2176..f6825604 100644 --- a/contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md +++ b/contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md @@ -13,7 +13,7 @@ we will implement metrics for: * AWS We will also implement metrics only for storage API calls for now. This feature -does introduces hooks into kubernetes code which can be used to add additonal metrics +does introduces hooks into kubernetes code which can be used to add additional metrics but we only focus on storage API calls here. ## Motivation @@ -50,7 +50,7 @@ the external Cloud Provider - we will use [Histogram](https://prometheus.io/docs emitting these metrics. We will be using `HistogramVec` type so as we can attach dimensions at runtime. All metrics will contain API action -being taken as a dimension. The cloudprovider maintainer may choose to add additonal dimensions as needed. If a +being taken as a dimension. The cloudprovider maintainer may choose to add additional dimensions as needed. If a dimension is not available at point of emission sentinel value `<n/a>` should be emitted as a placeholder. We are also interested in counter of cloudprovider API errors. `NewCounterVec` type will be used for keeping |