Merge pull request #410 from p0lyn0mial/generic_api_server_build_in_admission_plugins

Streamline the process of including admission controllers to generic server

1 files changed, 58 insertions, 0 deletions

diff --git a/contributors/design-proposals/apiserver-build-in-admission-plugins.md b/contributors/design-proposals/apiserver-build-in-admission-plugins.md
new file mode 100644
index 00000000..10708b1f
--- /dev/null
+++ b/contributors/design-proposals/apiserver-build-in-admission-plugins.md
@@ -0,0 +1,58 @@
+# Build some Admission Controllers into the Generic API server library
+
+**Related PR:**
+
+| Topic | Link |
+| ----- | ---- |
+| Admission Control | https://github.com/kubernetes/community/blob/master/contributors/design-proposals/admission_control.md |
+
+## Introduction
+
+An admission controller is a piece of code that intercepts requests to the Kubernetes API - think a middleware.
+The API server lets you have a whole chain of them. Each is run in sequence before a request is accepted 
+into the cluster. If any of the plugins in the sequence rejects the request, the entire request is rejected 
+immediately and an error is returned to the user.
+
+Many features in Kubernetes require an admission control plugin to be enabled in order to properly support the feature. 
+In fact in the [documentation](https://kubernetes.io/docs/admin/admission-controllers/#is-there-a-recommended-set-of-plug-ins-to-use) you will find 
+a recommended set of them to use.
+
+At the moment admission controllers are implemented as plugins and they have to be compiled into the 
+final binary in order to be used at a later time. Some even require an access to cache, an authorizer etc.
+This is where an admission plugin initializer kicks in. An admission plugin initializer is used to pass additional 
+configuration and runtime references to a cache, a client and an authorizer.
+
+To streamline the process of adding new plugins especially for aggregated API servers we would like to build some plugins 
+into the generic API server library and provide a plugin initializer. While anyone can author and register one, having a known set of 
+provided references let's people focus on what they need their admission plugin to do instead of paying attention to wiring.
+
+## Implementation
+
+The first step would involve creating a "standard" plugin initializer that would be part of the 
+generic API server. It would use kubeconfig to populate 
+[external clients](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubeapiserver/admission/initializer.go#L29) 
+and [external informers](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubeapiserver/admission/initializer.go#L35). 
+By default for servers that would be run on the kubernetes cluster in-cluster config would be used. 
+The standard initializer would also provide a client config for connecting to the core kube-apiserver. 
+Some API servers might be started as static pods, which don't have in-cluster configs. 
+In that case the config could be easily populated form the file. 
+
+The second step would be to move some plugins from [admission pkg](https://github.com/kubernetes/kubernetes/tree/master/plugin/pkg/admission) 
+to the generic API server library. Some admission plugins are used to ensure consistent user expectations. 
+These plugins should be moved. One example is the Namespace Lifecycle plugin which prevents users 
+from creating resources in non-existent namespaces.
+
+*Note*:
+For loading in-cluster configuration [visit](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/in-cluster/main.go#L30)
+ For loading the configuration directly from a file [visit](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/out-of-cluster/main.go)
+ 
+## How to add an admission plugin ?
+ At this point adding an admission plugin is very simple and boils down to performing the 
+following series of steps:
+ 1. Write an admission plugin
+ 2. Register the plugin 
+ 3. Reference the plugin in the admission chain
+
+**TODO**(p0lyn0mial): There is also a [sample apiserver](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-apiserver/main.go) to demonstrate the usage of the generic API library. 
+After implementation sample could would be placed there - copy & paste it here and include a reference.
+