diff options
| author | Vaibhav Kamra <vkamra@kasten.io> | 2017-08-27 23:40:56 -0700 |
|---|---|---|
| committer | Vaibhav Kamra <vkamra@kasten.io> | 2017-08-27 23:40:56 -0700 |
| commit | 8f90478df125f17748b02ae64eba3aeb7475dfc6 (patch) | |
| tree | 0dd829bce850a52a5c7c13b464952814cfbef2d5 | |
| parent | 7196a2537ecc2bdedca7a4df8cf878296e5bb5b5 (diff) | |
Address review feedback
| -rw-r--r-- | contributors/design-proposals/volume_stats_pvc_ref.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contributors/design-proposals/volume_stats_pvc_ref.md b/contributors/design-proposals/volume_stats_pvc_ref.md index 917421f5..0720a19f 100644 --- a/contributors/design-proposals/volume_stats_pvc_ref.md +++ b/contributors/design-proposals/volume_stats_pvc_ref.md @@ -41,7 +41,7 @@ type VolumeStats struct { - The limitation of this approach is that we're limited to reporting only what is available in the pod spec (Pod namespace and PVC claimname) ### Option 2 -- Modify the ```volumemanager::GetMountedVolumesForPod()``` (or add a new function) to return additional volume information from the ASOW/DSOW caches +- Modify the ```volumemanager::GetMountedVolumesForPod()``` (or add a new function) to return additional volume information from the actual/desired state-of-world caches - Use this to populate PVCRef in VolumeStats - This allows us to get information not available in the Pod spec such as the PV name/UID which can be used to label metrics - enables exposing/querying volume metrics by PV name |