diff options
| author | Adam Dymitruk <adam@dymitruk.com> | 2015-03-23 23:51:46 -0700 |
|---|---|---|
| committer | Adam Dymitruk <adam@dymitruk.com> | 2015-03-23 23:51:46 -0700 |
| commit | 8a901730fe7348d9bb207233f51a9713b77791b2 (patch) | |
| tree | 70797bce815dd47068294fe52623348ea7cff198 | |
| parent | cd5cc3bdf65d167d9bfc932619fda47744d12933 (diff) | |
Better wording for clean up.
Encouraging squashing by default leads to important history being lost. People new to different git flows may be doing themselves and the project a disservice without knowing.
| -rw-r--r-- | faster_reviews.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/faster_reviews.md b/faster_reviews.md index 142ac946..a2d00465 100644 --- a/faster_reviews.md +++ b/faster_reviews.md @@ -120,8 +120,8 @@ your whole PR is pretty trivial, you should instead put your fixups into a new commit and re-push. Your reviewer can then look at that commit on its own - so much faster to review than starting over. -We might still ask you to squash commits at the very end, for the sake of a clean -history. +We might still ask you to clean up your commits at the very end, for the sake +of a more readable history. ## 8. KISS, YAGNI, MVP, etc |