diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2019-09-06 13:37:20 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-09-06 13:37:20 -0700 |
| commit | 81ec4af0ed02b4c5c0917a16563250b2f45250c2 (patch) | |
| tree | 30f50fae35aad9f63d1a32753c6e852440a710c7 | |
| parent | 55907d2f4e78ad8d7e70ca09ffd4cae032a63f3c (diff) | |
| parent | 4add2dbfd254b05abf170afc3f4839dd4546b8e2 (diff) | |
Merge pull request #3643 from liggitt/api-review-validation
Add field/validation/behavior change to API review requirements
| -rw-r--r-- | sig-architecture/api-review-process.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sig-architecture/api-review-process.md b/sig-architecture/api-review-process.md index 42ff714b..b26a3f7e 100644 --- a/sig-architecture/api-review-process.md +++ b/sig-architecture/api-review-process.md @@ -72,6 +72,7 @@ Voluntary reviews apply towards non-core APIs that do not meet the [mandatory](# * Any new resource type * Any new version of a stable API * Any new functionality added to a stable API as defined by SIG Architecture and the API Reviewers + * Any change to the meaning, validation, or behavior of a field * The existing [API conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md) (and [API change guidelines](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md), if applicable) have been read and followed. 1. Request an API review for a PR or issue in the kubernetes org by adding the `api-review` label with a `/label api-review` comment (requests can be cancelled with a `/remove-label api-review` comment) |