summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Ashpole <dashpole@google.com>2017-12-20 14:37:56 -0800
committerGitHub <noreply@github.com>2017-12-20 14:37:56 -0800
commit7948e33ae28232ba6b46a6a9af1ffd1bfc6a3e8b (patch)
tree2d2b55f2801c340b878ae002f685a932c70d2ac6
parent41212d7f4c43a03487c6d88aace260763c4297d7 (diff)
cross out option 2
-rw-r--r--contributors/design-proposals/node/kubelet-eviction.md8
1 files changed, 4 insertions, 4 deletions
diff --git a/contributors/design-proposals/node/kubelet-eviction.md b/contributors/design-proposals/node/kubelet-eviction.md
index 5124b628..311236de 100644
--- a/contributors/design-proposals/node/kubelet-eviction.md
+++ b/contributors/design-proposals/node/kubelet-eviction.md
@@ -214,15 +214,15 @@ Therefore, no memory pressure. This will occur as long as memory.total_inactive
### Proposed solutions:
1. Set the cgroup event at `threshold*fraction`.
-For example, if `--eviction-hard=memory.available<200Mi`, set the cgroup event at `100Mi`.
+For example, if `--eviction-hard=memory.available<200Mi`, use `fraction=1/2` set the cgroup event at `100Mi`.
This way, when the eviction manager is triggered, it will likely observe memory pressure.
-This is not guaranteed to always work, but should prevent OOMs in most cases.
+This is not guaranteed to always work, but should prevent OOMs in most cases, and is simple to implement.
-2. Use Usage instead of Working Set to determine memory pressure
+~~2. Use Usage instead of Working Set to determine memory pressure
This would mean that the eviction manager and cgroup notifications use the same metric,
and thus the response is ideal: the eviction manager is triggered exactly when memory pressure occurs.
However, the eviction manager may often evict unneccessarily if there are large quantities of memory
-the kernel has not yet reclaimed.
+the kernel has not yet reclaimed.~~
3. Increase the syncloop interval after the threshold is crossed
For example, the eviction manager could start collecting observations every second instead of every