diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2019-05-22 05:12:08 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-05-22 05:12:08 -0700 |
| commit | 714c3647b919bafedccd97673e5e95edc82b541d (patch) | |
| tree | b62ebedf23e54c3470557842eebd68d1c972fa33 | |
| parent | d98f9dbfb349b9325573673e610e1b585fd1d990 (diff) | |
| parent | a02279e1b48953eb5918a4f471babc078fef61a4 (diff) | |
Merge pull request #3731 from nzoueidi/3642
Adding note to not use keywords and mentions in commit messages
| -rw-r--r-- | contributors/guide/README.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contributors/guide/README.md b/contributors/guide/README.md index e0a2564c..b946debb 100644 --- a/contributors/guide/README.md +++ b/contributors/guide/README.md @@ -204,6 +204,7 @@ Common new contributor PR issues are: * finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](#learn-about-sigs) section) * dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](http://velodrome.k8s.io/dashboard/db/bigquery-metrics?orgId=1)) * Not following [scalability good practices](scalability-good-practices.md) +* Include mentions (like @person) and [keywords](https://help.github.com/en/articles/closing-issues-using-keywords) which could close the issue (like fixes #xxxx) in commit messages. ## Code Review |