summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>2022-09-27 17:57:42 -0700
committerGitHub <noreply@github.com>2022-09-27 17:57:42 -0700
commit6a97ae2edc02607e5a484bd60fe2040ceed05168 (patch)
tree11bd876a526ab88fdc70dfbf6cc03ed65c117878
parent43e5efab6c09b0da980af34e7302c13cf19a0317 (diff)
parentd0cb25a2b33c0679b38f643012cca57b73ba4f00 (diff)
Merge pull request #6884 from valaparthvi/patch-1
Fix typos in the conformance-tests doc
-rw-r--r--contributors/devel/sig-architecture/conformance-tests.md9
1 files changed, 4 insertions, 5 deletions
diff --git a/contributors/devel/sig-architecture/conformance-tests.md b/contributors/devel/sig-architecture/conformance-tests.md
index ceb8e1f3..91026639 100644
--- a/contributors/devel/sig-architecture/conformance-tests.md
+++ b/contributors/devel/sig-architecture/conformance-tests.md
@@ -107,7 +107,7 @@ Generally speaking, the goals are to:
- Make sure tests that are already passing remain passing. If new OS-specific
functionality is added, it should be in a new test.
- Ensure that new tests covering Linux-specific functionality are tagged with `[LinuxOnly]`
-(see: [Kinds of Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md#kinds-of-tests),
+(see: [Kinds of Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md#kinds-of-tests)).
- Give future reviewers a reference to an active issue or documentation clarifying why a test
cannot run on Windows.
@@ -115,7 +115,7 @@ The tests that are running today:
- Rely only on container images that already have a multi-architecture manifest
including Windows versions, or have been ported by SIG-Windows
-(see [kubernetes-sigs/windows-testing/images](https://github.com/kubernetes-sigs/windows-testing/tree/master/images)
+(see [kubernetes-sigs/windows-testing/images](https://github.com/kubernetes-sigs/windows-testing/tree/master/images)).
- Do not depend on any functionality that is different or not available on Windows. The full list
is available in the Windows Kubernetes docs under [api](https://kubernetes.io/docs/setup/windows/intro-windows-in-kubernetes/#api).
A brief summary is included here as a starting point. If the docs are insufficient
@@ -139,7 +139,7 @@ implicitly by Docker or ContainerD, not by the kubelet. Do not check properties
- Networking
- Pods set `HostNetwork=true`. For Windows, this can only be enabled for Windows Privileged Containers. In other cases, the Pod will not start.
- Network and DNS settings must be passed through CNI. Windows does not use `/etc/resolv.conf`, so tests should not rely on reading that file to check DNS settings.
- - If you to check network settings such as dns search lists, please use [agnhost](https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost) to output needed data from the container.
+ - If you want to check network settings such as dns search lists, please use [agnhost](https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost) to output needed data from the container.
- Windows treats all DNS lookups with a `.` to be FQDN, not PQDN. For example `kubernetes` will resolve as a PQDN,
but `kubernetes.default` will be resolved as a FQDN and fail.
- ICMP only works between pods on the same network, and are not routable to external networks. TCP/UDP are routable.
@@ -276,8 +276,7 @@ this approval process:
- changes to the conformance criteria or process
- changes to the conformance infrastructure code
-There are six columns in this board. New PRs should enter in the To Triage
-column, and [Conformance test reviewers] will pick it up from there and move it
+New PRs should enter in the To Triage column, and [Conformance test reviewers] will pick it up from there and move it
through the process. New end-to-end tests that are intended to be promoted to
conformance tests in the future may be added to this board, but they will not
move all the way to the Needs Approval column, as that is intended only for the