diff options
| author | Kubernetes Submit Queue <k8s-merge-robot@users.noreply.github.com> | 2017-10-20 11:17:11 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-20 11:17:11 -0700 |
| commit | 638a41335a28c3c30f1bf41523be9082f04b2f5d (patch) | |
| tree | 3f1b6313ff28980e0ebfee39d6cd6fcb00cb63dc | |
| parent | 0fd19f68024904e356daa230a3b6ce192ef3c811 (diff) | |
| parent | 62ec44978f32466ae9c256fd2e36bce7d5971fc7 (diff) | |
Merge pull request #1242 from wongma7/metric-names
Automatic merge from submit-queue.
Update volume operations metric names as implemented
@verult PTAL, thanks! https://github.com/kubernetes/kubernetes/pull/50036#issuecomment-338079916
| -rw-r--r-- | contributors/design-proposals/storage/volume-metrics.md | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/contributors/design-proposals/storage/volume-metrics.md b/contributors/design-proposals/storage/volume-metrics.md index 73c0d96c..59c15fb9 100644 --- a/contributors/design-proposals/storage/volume-metrics.md +++ b/contributors/design-proposals/storage/volume-metrics.md @@ -50,13 +50,13 @@ Following is a sample of metrics (not exhaustive) that will be added by this pro ``` storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_attach" } storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_detach" } -storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "provision" } +storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "volume_provision" } storage_operation_duration_seconds { volume_plugin = "gce-pd", operation_name = "volume_delete" } storage_operation_duration_seconds { volume_plugin = "vsphere", operation_name = "volume_mount" } storage_operation_duration_seconds { volume_plugin = "iscsi" , operation_name = "volume_unmount" } -storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "mount_device" } storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "unmount_device" } -storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volume" } +storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" } +storage_operation_duration_seconds { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" } ``` Similarly errors will be named: @@ -64,13 +64,13 @@ Similarly errors will be named: ``` storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_attach" } storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_detach" } -storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "provision" } +storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "volume_provision" } storage_operation_errors_total { volume_plugin = "gce-pd", operation_name = "volume_delete" } storage_operation_errors_total { volume_plugin = "vsphere", operation_name = "volume_mount" } storage_operation_errors_total { volume_plugin = "iscsi" , operation_name = "volume_unmount" } -storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "mount_device" } storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "unmount_device" } -storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volume" } +storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" } +storage_operation_errors_total { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" } ``` ### Implementation Detail |