summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorParth Oberoi <parthoberoi@hotmail.com>2015-01-20 05:02:13 +0530
committerParth Oberoi <parthoberoi@hotmail.com>2015-01-20 05:02:13 +0530
commit61d146fd7faae5047f02c46f8454a186a8d99daf (patch)
treefb98191f57437c9888dea8f11772af1b75e5162a
parentce93f7027812035c48e20a539ff9d74940f284bd (diff)
typo fixed
-rw-r--r--collab.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/collab.md b/collab.md
index c4644048..633b7682 100644
--- a/collab.md
+++ b/collab.md
@@ -12,7 +12,7 @@ For the time being, most of the people working on this project are in the US and
## Code reviews
-All changes must be code reviewed. For non-maintainers this is obvious, since you can't commit anyway. But even for maintainers, we want all changes to get at least one review, preferably from someone who knows the areas the change touches. For non-trivial changes we may want two reviewers. The primary reviewer will make this decision and nominate a second reviewer, if needed. Except for trivial changes, PRs should sit for at least a 2 hours to allow for wider review.
+All changes must be code reviewed. For non-maintainers this is obvious, since you can't commit anyway. But even for maintainers, we want all changes to get at least one review, preferably from someone who knows the areas the change touches. For non-trivial changes we may want two reviewers. The primary reviewer will make this decision and nominate a second reviewer, if needed. Except for trivial changes, PRs should sit for at least 2 hours to allow for wider review.
Most PRs will find reviewers organically. If a maintainer intends to be the primary reviewer of a PR they should set themselves as the assignee on GitHub and say so in a reply to the PR. Only the primary reviewer of a change should actually do the merge, except in rare cases (e.g. they are unavailable in a reasonable timeframe).