diff options
| author | Cheng Xing <cxing@google.com> | 2017-08-17 19:51:49 -0700 |
|---|---|---|
| committer | Cheng Xing <cxing@google.com> | 2017-08-18 11:23:21 -0700 |
| commit | 5091fef670761494d70e235824f5ff6218fead88 (patch) | |
| tree | 212ffd847151475bdc65d9d34409d523216007b5 | |
| parent | 2fbb4a81ef3baa2f163acb19bb807ef915a5e6ed (diff) | |
Added notes regarding symlinked directories; updated atomic driver installation.
| -rw-r--r-- | contributors/design-proposals/flexvolume-deployment.md | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/contributors/design-proposals/flexvolume-deployment.md b/contributors/design-proposals/flexvolume-deployment.md index 80e86308..6e4e3881 100644 --- a/contributors/design-proposals/flexvolume-deployment.md +++ b/contributors/design-proposals/flexvolume-deployment.md @@ -32,7 +32,9 @@ Iterating through the list of plugins inside `InitPlugins()` from `volume/plugin Because Flexvolume has two separate plugin instantiations (attachable and non-attachable), it's worth considering the case when a driver that implements attach/detach is replaced with a driver that does not, or vice versa. This does not cause an issue because plugins are recreated every time the driver directory is changed. -There is a possibility that a Flexvolume command execution occurs at the same time as the DaemonSet updates the driver, which leads to a bad execution. This cannot be solved within the Kubernetes system without an overhaul. Instead, this is discussed in [Atomic Driver Installation](#atomic-driver-installation) as part of the deployment mechanism. As part of the solution, the Prober will ignore all files that begins with "." in the driver directory. +There is a possibility that a Flexvolume command execution occurs at the same time as the driver is updated, which leads to a bad execution. This cannot be solved within the Kubernetes system without an overhaul. Instead, this is discussed in [Atomic Driver Installation](#atomic-driver-installation) as part of the deployment mechanism. As part of the solution, the Prober will **ignore all files that begins with "."** in the driver directory. + +Word of caution about symlinks in the Flexvolume plugin directory: as a result of the recursive filesystem watch implementation, if a symlink links to a directory, unless the directory is visible to the prober (i.e. it's inside the Flexvolume plugin directory and does not start with '.'), the directory's files and subdirectories are not added to filesystem watch, thus their change will not trigger a probe. ## **Alternative Designs** @@ -102,6 +104,8 @@ set -o pipefail VENDOR=k8s.io DRIVER=nfs +# Assuming the single driver file is located at /$DRIVER inside the DaemonSet image. + driver_dir=$VENDOR${VENDOR:+"~"}${DRIVER} if [ ! -d "/flexmnt/$driver_dir" ]; then mkdir "/flexmnt/$driver_dir" @@ -145,7 +149,7 @@ spec: ### Atomic Driver Installation Regular file copy is not an atomic file operation, so if it were used to install the driver, it's possible that kubelet or controller manager executes the driver when it's partially installed, or the driver gets modified while it's being executed. Care must be taken to ensure the installation operation is atomic. -The deployment script provided above uses renaming, which is atomic, to ensure that from the perspective of kubelet or controller manager, the driver file is completely written to disk in a single operation. +The deployment script provided above uses renaming, which is atomic, to ensure that from the perspective of kubelet or controller manager, the driver file is completely written to disk in a single operation. The file is first installed with a name prefixed with '.', which the prober ignores. ### Alternatives |