diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2020-12-07 13:35:11 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-07 13:35:11 -0800 |
| commit | 4abc0b58dc808ff0ee786200495fa57704739e5c (patch) | |
| tree | aad8fbab4333bf8fb3507a641a822e59fd48a2c3 | |
| parent | 599b7547cf8c9cbf8274c58ee94d470898b16c9b (diff) | |
| parent | ed6f2181efffccf27990a85b06f15fb15f1bc5a3 (diff) | |
Merge pull request #5352 from celanthe/patch-3
Added link to best practices section
| -rw-r--r-- | contributors/guide/contributing.md | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/contributors/guide/contributing.md b/contributors/guide/contributing.md index 573068da..2b74f4f1 100644 --- a/contributors/guide/contributing.md +++ b/contributors/guide/contributing.md @@ -94,10 +94,11 @@ Note: if your pull request isn't getting enough attention, you can use the [#pr- - Make sure you don't include `@mentions` or `fixes` keywords in your git commit messages. These should be included in the PR body instead. - When you make a PR for small change (such as fixing a typo, style change, or grammar fix), please squash your commits so that we can maintain a cleaner git history. - Make sure you include a clear and detailed PR description explaining the reasons for the changes, and ensuring there is sufficient information for the reviewer to understand your PR. -- Additional Readings : +- Additional Readings: - [chris.beams.io/posts/git-commit/](https://chris.beams.io/posts/git-commit/) - - [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests ) - - [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git ) + - [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests) + - [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git) + - [https://mtlynch.io/code-review-love/](https://mtlynch.io/code-review-love/) ## Testing |