diff options
| author | Steve Kuznetsov <skuznets@redhat.com> | 2017-08-03 18:08:53 -0700 |
|---|---|---|
| committer | Steve Kuznetsov <skuznets@redhat.com> | 2017-08-08 13:57:43 -0700 |
| commit | 416a7f8bf0ff57cf6d8ce48a1d38703d166e1d71 (patch) | |
| tree | e4786c22a31794a5b26e0b2d11bc43274e8e2c9d | |
| parent | b56f18ef51ab102e5c8c675f55cf437fa05ccf75 (diff) | |
Update OWNERS documents to reflect recent changes
`kubernetes/test-infra` pull requests #3766 and #3898 changed the
behavior of the OWNERS process slightly. This patch updates the
documenation to be more up-to-date.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
| -rw-r--r-- | contributors/devel/owners.md | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/contributors/devel/owners.md b/contributors/devel/owners.md index 6ca56594..aea8579e 100644 --- a/contributors/devel/owners.md +++ b/contributors/devel/owners.md @@ -27,7 +27,7 @@ OWNERS files are in YAML format and support the following keys: - `approvers`: a list of GitHub usernames or aliases that can `/approve` a PR - [DEPRECATED] `assignees`: do not use, equivalent to `approvers` - ([kubernetes/test-infra#3851](https://github.com/kubernetes/test-infra/issues/3851)) + ([kubernetes/test-infra#3851](https://github.com/kubernetes/test-infra/issues/3851)) - `labels`: a list of GitHub labels to automatically apply to a PR - `reviewers`: a list of GitHub usernames or aliases that are good candidates to `/lgtm` a PR @@ -41,7 +41,7 @@ approvers: - alice - bob # this is a comment reviewers: - - alice + - alice - carol # this is another comment - sig-foo # this is an alias ``` @@ -57,7 +57,7 @@ publicly auditable. A sample OWNERS_ALISES file looks like: -``` +``` aliases: sig-foo: - david @@ -67,6 +67,8 @@ aliases: - frank ``` +GitHub usernames and aliases listed in OWNERS files are case-insensitive. + ## Code Review Process This is a simplified description of our [full PR testing and merge @@ -153,7 +155,7 @@ is the state of today. - This hurts the project in general as its general noise level increases over time - Instead, close PR's that are untouched after too long (we currently have a bot do this after 90 days) - + ## Implementation ### [`mungegithub`](https://github.com/kubernetes/test-infra/tree/master/mungegithub) @@ -185,7 +187,7 @@ stateful, in that restarting it means it loses track of which things it has mung - [full description of the algorithm](https://github.com/kubernetes/test-infra/blob/6f5df70c29528db89d07106a8156411068518cbc/mungegithub/mungers/approval-handler.go#L99-L111) - [munger: - submit-queue](https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/submit-queue.go) + submit-queue](https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/submit-queue.go) - responsible for merging PR's - responsible for updating a GitHub status check explaining why a PR can't be merged (eg: a missing `lgtm` or `approved` label) |