diff options
| author | guineveresaenger <guineveresaenger@gmail.com> | 2018-02-21 13:38:17 -0800 |
|---|---|---|
| committer | guineveresaenger <guineveresaenger@gmail.com> | 2018-02-22 14:42:13 -0800 |
| commit | 405849f487e10bbf24e2a952f9ff2e68f5bf5bf3 (patch) | |
| tree | 7a0c8df80ee1ce4fb9d2f2bdb2a8d4e4c798e99c | |
| parent | 66eb35601df6f472b5e2edf2edc24335dbca0593 (diff) | |
Release Notes: Title added; minor cleanup. Faster reviews tombstone added. Minor cleanup in pull-requests.md
| -rw-r--r-- | contributors/devel/faster_reviews.md | 7 | ||||
| -rw-r--r-- | contributors/guide/pull-requests.md | 3 | ||||
| -rw-r--r-- | contributors/guide/release-notes.md | 8 |
3 files changed, 9 insertions, 9 deletions
diff --git a/contributors/devel/faster_reviews.md b/contributors/devel/faster_reviews.md index 66fe9ab0..d0fe7e37 100644 --- a/contributors/devel/faster_reviews.md +++ b/contributors/devel/faster_reviews.md @@ -1,3 +1,4 @@ -# How to get faster PR reviews - -Merged with the [pull requests doc](/contributors/guide/pull-requests.md#best-practices-for-faster-reviews). +The contents of this file have been moved to https://git.k8s.io/community/contributors/guide/pull-requests.md. + <!-- + This file is a placeholder to preserve links. Please remove after 3 months or the release of kubernetes 1.10, whichever comes first. + --> diff --git a/contributors/guide/pull-requests.md b/contributors/guide/pull-requests.md index c87f74fe..ef50efb7 100644 --- a/contributors/guide/pull-requests.md +++ b/contributors/guide/pull-requests.md @@ -107,7 +107,7 @@ The GitHub robots will add and remove the `do-not-merge/hold` label as you use t ## Comment Commands Reference -[The commands doc](https://prow.k8s.io/command-help.html) contains a reference for all comment commands. +[The commands doc](https://go.k8s.io/bot-commands) contains a reference for all comment commands. ## Automation @@ -122,7 +122,6 @@ comment-command to re-run that test. e.g. > The following tests failed, say /retest to rerun them all. # Why was my pull request closed? -<!-- TODO: update this information to accurately reflect lifecycle:stale label --> Pull requests older than 90 days will be closed. Exceptions can be made for pull requests that have active review comments, or that are awaiting other dependent pull requests. Closed pull requests are easy to recreate, and little work is lost by closing a pull request that subsequently needs to be reopened. We want to limit the total number of pull requests in flight to: * Maintain a clean project diff --git a/contributors/guide/release-notes.md b/contributors/guide/release-notes.md index 6015f12e..e9fcb4df 100644 --- a/contributors/guide/release-notes.md +++ b/contributors/guide/release-notes.md @@ -1,3 +1,5 @@ +# Adding Release Notes + On the kubernetes/kubernetes repository, release notes are required for any pull request with user-visible changes, such as bug-fixes, feature additions, and output format changes. To meet this requirement, do one of the following: @@ -28,8 +30,6 @@ For pull requests that don't need to be mentioned at release time, just write "N The `/release-note-none` comment command can still be used as an alternative to writing "NONE" in the release-note block if it is left empty. -To see how to format your release notes, view the kubernetes/kubernetes[pull request template](https://git.k8s.io/kubernetes/.github/PULL_REQUEST_TEMPLATE.md) for a brief example. pull request titles and body comments can be modified at any time prior to the release to make them friendly for release notes. - -Release notes apply to pull requests on the master branch. For cherry-pick pull requests, see the [cherry-pick instructions](contributors/devel/cherry-picks.md). The only exception to these rules is when a pull request is not a cherry-pick and is targeted directly to the non-master branch. In this case, a `release-note-*` label is required for that non-master pull request. +To see how to format your release notes, view the kubernetes/kubernetes [pull request template](https://git.k8s.io/kubernetes/.github/PULL_REQUEST_TEMPLATE.md) for a brief example. pull request titles and body comments can be modified at any time prior to the release to make them friendly for release notes. -Now that your release notes are in shape, let's look at how the pull request gets tested and merged.
\ No newline at end of file +Release notes apply to pull requests on the master branch. For cherry-pick pull requests, see the [cherry-pick instructions](contributors/devel/cherry-picks.md). The only exception to these rules is when a pull request is not a cherry-pick and is targeted directly to the non-master branch. In this case, a `release-note-*` label is required for that non-master pull request.
\ No newline at end of file |
