diff options
| author | Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> | 2022-03-23 07:36:09 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-23 07:36:09 -0700 |
| commit | 3a1111f54c6b7261ffa0a0697b526a405210a7ba (patch) | |
| tree | d2bc358981410d4c7faede5e0dcb843c58b14e84 | |
| parent | 8f0e7a9ac1d2bf5d07a7b4b3fda8e45e5cbdb95b (diff) | |
| parent | 9a4dbd387823f2862ea2c5fa5209ef9b5863ff8e (diff) | |
Merge pull request #6557 from deads2k/tidy-up
Remove recommendation for condition heartbeat
| -rw-r--r-- | contributors/devel/sig-architecture/api-conventions.md | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/contributors/devel/sig-architecture/api-conventions.md b/contributors/devel/sig-architecture/api-conventions.md index f1bc0bf3..69e64b67 100644 --- a/contributors/devel/sig-architecture/api-conventions.md +++ b/contributors/devel/sig-architecture/api-conventions.md @@ -406,8 +406,6 @@ following fields, but must contain at least `type` and `status` fields: Message *string `json:"message,omitempty" description:"human-readable message indicating details about last transition"` // +optional - LastHeartbeatTime *unversioned.Time `json:"lastHeartbeatTime,omitempty" description:"last time we got an update on a given condition"` - // +optional LastTransitionTime *unversioned.Time `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"` ``` @@ -417,9 +415,6 @@ Do not use fields that you don't need - simpler is better. Use of the `Reason` field is encouraged. -Use the `LastHeartbeatTime` with great caution - frequent changes to this field -can cause a large fan-out effect for some resources. - Condition types should be named in PascalCase. Short condition names are preferred (e.g. "Ready" over "MyResourceReady"). |