diff options
| author | Ed Costello <epc@epcostello.com> | 2015-06-11 01:11:44 -0400 |
|---|---|---|
| committer | Ed Costello <epc@epcostello.com> | 2015-06-12 18:47:28 -0400 |
| commit | 2c9669befd4fe4580bc77bc6f3c40236a07bc651 (patch) | |
| tree | 03c93661743e0618f34cb7543f8e8baf040d0285 | |
| parent | 2f18beac68176d99d4137a59faee0e653571ff63 (diff) | |
Copy edits for spelling errors and typos
Signed-off-by: Ed Costello <epc@epcostello.com>
| -rw-r--r-- | collab.md | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -8,7 +8,7 @@ First and foremost: as a potential contributor, your changes and ideas are welco ## Code reviews -All changes must be code reviewed. For non-maintainers this is obvious, since you can't commit anyway. But even for maintainers, we want all changes to get at least one review, preferably (for non-trivial changes obligately) from someone who knows the areas the change touches. For non-trivial changes we may want two reviewers. The primary reviewer will make this decision and nominate a second reviewer, if needed. Except for trivial changes, PRs should not be committed until relevant parties (e.g. owners of the subsystem affected by the PR) have had a reasonable chance to look at PR in their local business hours. +All changes must be code reviewed. For non-maintainers this is obvious, since you can't commit anyway. But even for maintainers, we want all changes to get at least one review, preferably (for non-trivial changes obligatorily) from someone who knows the areas the change touches. For non-trivial changes we may want two reviewers. The primary reviewer will make this decision and nominate a second reviewer, if needed. Except for trivial changes, PRs should not be committed until relevant parties (e.g. owners of the subsystem affected by the PR) have had a reasonable chance to look at PR in their local business hours. Most PRs will find reviewers organically. If a maintainer intends to be the primary reviewer of a PR they should set themselves as the assignee on GitHub and say so in a reply to the PR. Only the primary reviewer of a change should actually do the merge, except in rare cases (e.g. they are unavailable in a reasonable timeframe). |
