1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
|
package image
import (
"fmt"
"os"
"path"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/kube"
"github.com/argoproj-labs/argocd-image-updater/registry-scanner/test/fake"
"github.com/argoproj-labs/argocd-image-updater/registry-scanner/test/fixture"
)
func Test_ParseCredentialAnnotation(t *testing.T) {
t.Run("Parse valid credentials definition of type secret", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secret:mynamespace/mysecret#anyfield", true)
assert.NoError(t, err)
assert.Equal(t, "gcr.io", src.Registry)
assert.Equal(t, "mynamespace", src.SecretNamespace)
assert.Equal(t, "mysecret", src.SecretName)
assert.Equal(t, "anyfield", src.SecretField)
})
t.Run("Parse valid credentials definition of type pullsecret", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=pullsecret:mynamespace/mysecret", true)
assert.NoError(t, err)
assert.Equal(t, "gcr.io", src.Registry)
assert.Equal(t, "mynamespace", src.SecretNamespace)
assert.Equal(t, "mysecret", src.SecretName)
assert.Equal(t, ".dockerconfigjson", src.SecretField)
})
t.Run("Parse invalid secret definition - missing registry", func(t *testing.T) {
src, err := ParseCredentialSource("secret:mynamespace/mysecret#anyfield", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid secret definition - empty registry", func(t *testing.T) {
src, err := ParseCredentialSource("=secret:mynamespace/mysecret#anyfield", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid secret definition - unknown credential type", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secrets:mynamespace/mysecret#anyfield", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid secret definition - missing field", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secret:mynamespace/mysecret#", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid secret definition - missing namespace", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secret:/mysecret#anyfield", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid credential definition - missing name", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secret:mynamespace/#anyfield", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid credential definition - missing most", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=secret:", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid pullsecret definition - missing namespace", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=pullsecret:/mysecret", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse invalid credential definition - missing name", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=pullsecret:mynamespace", true)
assert.Error(t, err)
assert.Nil(t, src)
})
t.Run("Parse valid credentials definition from environment", func(t *testing.T) {
src, err := ParseCredentialSource("env:DUMMY_SECRET", false)
require.NoError(t, err)
require.NotNil(t, src)
assert.Equal(t, "DUMMY_SECRET", src.EnvName)
})
t.Run("Parse valid credentials definition from environment", func(t *testing.T) {
src, err := ParseCredentialSource("env:DUMMY_SECRET", false)
require.NoError(t, err)
require.NotNil(t, src)
assert.Equal(t, "DUMMY_SECRET", src.EnvName)
})
t.Run("Parse external script credentials", func(t *testing.T) {
src, err := ParseCredentialSource("ext:/tmp/a.sh", false)
require.NoError(t, err)
assert.Equal(t, CredentialSourceExt, src.Type)
assert.Equal(t, "/tmp/a.sh", src.ScriptPath)
})
}
func Test_ParseCredentialReference(t *testing.T) {
t.Run("Parse valid credentials definition of type secret", func(t *testing.T) {
src, err := ParseCredentialSource("secret:mynamespace/mysecret#anyfield", false)
assert.NoError(t, err)
assert.Equal(t, "", src.Registry)
assert.Equal(t, "mynamespace", src.SecretNamespace)
assert.Equal(t, "mysecret", src.SecretName)
assert.Equal(t, "anyfield", src.SecretField)
})
t.Run("Parse valid credentials definition of type pullsecret", func(t *testing.T) {
src, err := ParseCredentialSource("gcr.io=pullsecret:mynamespace/mysecret", false)
assert.NoError(t, err)
assert.Equal(t, "gcr.io", src.Registry)
assert.Equal(t, "mynamespace", src.SecretNamespace)
assert.Equal(t, "mysecret", src.SecretName)
assert.Equal(t, ".dockerconfigjson", src.SecretField)
})
t.Run("Parse invalid secret definition - empty registry", func(t *testing.T) {
src, err := ParseCredentialSource("=secret:mynamespace/mysecret#anyfield", false)
assert.Error(t, err)
assert.Nil(t, src)
})
}
func Test_FetchCredentialsFromSecret(t *testing.T) {
t.Run("Fetch credentials from secret", func(t *testing.T) {
secretData := make(map[string][]byte)
secretData["username_password"] = []byte(fmt.Sprintf("%s:%s", "foo", "bar"))
secret := fixture.NewSecret("test", "test", secretData)
clientset := fake.NewFakeClientsetWithResources(secret)
credSrc := &CredentialSource{
Type: CredentialSourceSecret,
SecretNamespace: "test",
SecretName: "test",
SecretField: "username_password",
}
creds, err := credSrc.FetchCredentials("NA", &kube.KubernetesClient{Clientset: clientset})
require.NoError(t, err)
require.NotNil(t, creds)
assert.Equal(t, "foo", creds.Username)
assert.Equal(t, "bar", creds.Password)
credSrc.SecretNamespace = "test1" // test with a wrong SecretNamespace
creds, err = credSrc.FetchCredentials("NA", &kube.KubernetesClient{Clientset: clientset})
require.Error(t, err)
require.Nil(t, creds)
})
t.Run("Fetch credentials from secret with invalid config", func(t *testing.T) {
secretData := make(map[string][]byte)
secretData["username_password"] = []byte(fmt.Sprintf("%s:%s", "foo", "bar"))
secret := fixture.NewSecret("test", "test", secretData)
clientset := fake.NewFakeClientsetWithResources(secret)
credSrc := &CredentialSource{
Type: CredentialSourceSecret,
SecretNamespace: "test",
SecretName: "test",
SecretField: "username_password",
}
creds, err := credSrc.FetchCredentials("NA", nil)
require.Error(t, err) // should fail with "could not fetch credentials: no Kubernetes client given"
require.Nil(t, creds)
credSrc.SecretField = "BAD" // test with a wrong SecretField
creds, err = credSrc.FetchCredentials("NA", &kube.KubernetesClient{Clientset: clientset})
require.Error(t, err)
require.Nil(t, creds)
})
}
func Test_FetchCredentialsFromPullSecret(t *testing.T) {
t.Run("Fetch credentials from pull secret", func(t *testing.T) {
dockerJson := fixture.MustReadFile("../../test/testdata/docker/valid-config.json")
secretData := make(map[string][]byte)
secretData[pullSecretField] = []byte(dockerJson)
pullSecret := fixture.NewSecret("test", "test", secretData)
clientset := fake.NewFakeClientsetWithResources(pullSecret)
credSrc := &CredentialSource{
Type: CredentialSourcePullSecret,
Registry: "https://registry-1.docker.io/v2",
SecretNamespace: "test",
SecretName: "test",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", &kube.KubernetesClient{Clientset: clientset})
require.NoError(t, err)
require.NotNil(t, creds)
assert.Equal(t, "foo", creds.Username)
assert.Equal(t, "bar", creds.Password)
credSrc.SecretNamespace = "test1" // test with a wrong SecretNamespace
creds, err = credSrc.FetchCredentials("https://registry-1.docker.io", &kube.KubernetesClient{Clientset: clientset})
require.Error(t, err)
require.Nil(t, creds)
})
t.Run("Fetch credentials from pull secret with invalid config", func(t *testing.T) {
dockerJson := fixture.MustReadFile("../../test/testdata/docker/valid-config.json")
dockerJson = strings.ReplaceAll(dockerJson, "auths", "BAD-KEY")
secretData := make(map[string][]byte)
secretData[pullSecretField] = []byte(dockerJson)
pullSecret := fixture.NewSecret("test", "test", secretData)
clientset := fake.NewFakeClientsetWithResources(pullSecret)
credSrc := &CredentialSource{
Type: CredentialSourcePullSecret,
Registry: "https://registry-1.docker.io/v2",
SecretNamespace: "test",
SecretName: "test",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", &kube.KubernetesClient{Clientset: clientset})
require.Error(t, err) // should fail with "no credentials in image pull secret"
require.Nil(t, creds)
creds, err = credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Error(t, err) // should fail with "could not fetch credentials: no Kubernetes client given"
require.Nil(t, creds)
})
t.Run("Fetch credentials from pull secret with protocol stripped", func(t *testing.T) {
dockerJson := fixture.MustReadFile("../../test/testdata/docker/valid-config-noproto.json")
secretData := make(map[string][]byte)
secretData[pullSecretField] = []byte(dockerJson)
pullSecret := fixture.NewSecret("test", "test", secretData)
clientset := fake.NewFakeClientsetWithResources(pullSecret)
credSrc := &CredentialSource{
Type: CredentialSourcePullSecret,
Registry: "https://registry-1.docker.io/v2",
SecretNamespace: "test",
SecretName: "test",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", &kube.KubernetesClient{Clientset: clientset})
require.NoError(t, err)
require.NotNil(t, creds)
assert.Equal(t, "foo", creds.Username)
assert.Equal(t, "bar", creds.Password)
})
}
func Test_FetchCredentialsFromEnv(t *testing.T) {
t.Run("Fetch credentials from environment", func(t *testing.T) {
err := os.Setenv("MY_SECRET_ENV", "foo:bar")
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceEnv,
Registry: "https://registry-1.docker.io/v2",
EnvName: "MY_SECRET_ENV",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.NoError(t, err)
require.NotNil(t, creds)
assert.Equal(t, "foo", creds.Username)
assert.Equal(t, "bar", creds.Password)
})
t.Run("Fetch credentials from environment with missing env var", func(t *testing.T) {
err := os.Setenv("MY_SECRET_ENV", "")
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceEnv,
Registry: "https://registry-1.docker.io/v2",
EnvName: "MY_SECRET_ENV",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Error(t, err)
require.Nil(t, creds)
})
t.Run("Fetch credentials from environment with invalid value in env var", func(t *testing.T) {
for _, value := range []string{"babayaga", "foo:", "bar:", ":"} {
err := os.Setenv("MY_SECRET_ENV", value)
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceEnv,
Registry: "https://registry-1.docker.io/v2",
EnvName: "MY_SECRET_ENV",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Error(t, err)
require.Nil(t, creds)
}
})
}
func Test_FetchCredentialsFromExt(t *testing.T) {
t.Run("Fetch credentials from external script - valid output", func(t *testing.T) {
pwd, err := os.Getwd()
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceExt,
Registry: "https://registry-1.docker.io/v2",
ScriptPath: path.Join(pwd, "..", "..", "test", "testdata", "scripts", "get-credentials-valid.sh"),
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.NoError(t, err)
require.NotNil(t, creds)
assert.Equal(t, "username", creds.Username)
assert.Equal(t, "password", creds.Password)
})
t.Run("Fetch credentials from external script - invalid script output", func(t *testing.T) {
pwd, err := os.Getwd()
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceExt,
Registry: "https://registry-1.docker.io/v2",
ScriptPath: path.Join(pwd, "..", "..", "test", "testdata", "scripts", "get-credentials-invalid.sh"),
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Errorf(t, err, "invalid script output")
require.Nil(t, creds)
})
t.Run("Fetch credentials from external script - script does not exist", func(t *testing.T) {
pwd, err := os.Getwd()
require.NoError(t, err)
credSrc := &CredentialSource{
Type: CredentialSourceExt,
Registry: "https://registry-1.docker.io/v2",
ScriptPath: path.Join(pwd, "..", "..", "test", "testdata", "scripts", "get-credentials-notexist.sh"),
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Errorf(t, err, "no such file or directory")
require.Nil(t, creds)
})
t.Run("Fetch credentials from external script - relative path", func(t *testing.T) {
credSrc := &CredentialSource{
Type: CredentialSourceExt,
Registry: "https://registry-1.docker.io/v2",
ScriptPath: "get-credentials-notexist.sh",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Errorf(t, err, "path to script must be absolute")
require.Nil(t, creds)
})
}
func Test_FetchCredentialsFromUnknown(t *testing.T) {
t.Run("Fetch credentials from unknown type", func(t *testing.T) {
credSrc := &CredentialSource{
Type: CredentialSourceType(-1),
Registry: "https://registry-1.docker.io/v2",
}
creds, err := credSrc.FetchCredentials("https://registry-1.docker.io", nil)
require.Error(t, err) // should fail with "unknown credential type"
require.Nil(t, creds)
})
}
func Test_ParseDockerConfig(t *testing.T) {
t.Run("Parse valid Docker configuration with matching registry", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config.json")
username, password, err := parseDockerConfigJson("https://registry-1.docker.io", config)
require.NoError(t, err)
assert.Equal(t, "foo", username)
assert.Equal(t, "bar", password)
})
t.Run("Parse valid Docker configuration with matching registry as prefix", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config-noproto.json")
username, password, err := parseDockerConfigJson("https://registry-1.docker.io", config)
require.NoError(t, err)
assert.Equal(t, "foo", username)
assert.Equal(t, "bar", password)
})
t.Run("Parse valid Docker configuration with matching http registry as prefix", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config-noproto.json")
username, password, err := parseDockerConfigJson("http://registry-1.docker.io", config)
require.NoError(t, err)
assert.Equal(t, "foo", username)
assert.Equal(t, "bar", password)
})
t.Run("Parse valid Docker configuration with matching no-protocol registry as prefix", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config-noproto.json")
username, password, err := parseDockerConfigJson("registry-1.docker.io", config)
require.NoError(t, err)
assert.Equal(t, "foo", username)
assert.Equal(t, "bar", password)
})
t.Run("Parse valid Docker configuration with matching registry as prefix with / in the end", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config-noproto.json")
username, password, err := parseDockerConfigJson("https://registry-1.docker.io/", config)
require.NoError(t, err)
assert.Equal(t, "foo", username)
assert.Equal(t, "bar", password)
})
t.Run("Parse valid Docker configuration without matching registry", func(t *testing.T) {
config := fixture.MustReadFile("../../test/testdata/docker/valid-config.json")
username, password, err := parseDockerConfigJson("https://gcr.io", config)
assert.Error(t, err)
assert.Empty(t, username)
assert.Empty(t, password)
})
}
|
