1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
|
package argocd
import (
"bytes"
"crypto/sha256"
"encoding/hex"
"errors"
"fmt"
"os"
"path"
"path/filepath"
"text/template"
"sigs.k8s.io/kustomize/api/konfig"
"sigs.k8s.io/kustomize/api/types"
"sigs.k8s.io/kustomize/kyaml/kio"
"sigs.k8s.io/kustomize/kyaml/order"
kyaml "sigs.k8s.io/kustomize/kyaml/yaml"
"github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/image"
"github.com/argoproj-labs/argocd-image-updater/ext/git"
"github.com/argoproj-labs/argocd-image-updater/registry-scanner/pkg/log"
"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
)
// templateCommitMessage renders a commit message template and returns it as
// as a string. If the template could not be rendered, returns a default
// message.
func TemplateCommitMessage(tpl *template.Template, appName string, changeList []ChangeEntry) string {
var cmBuf bytes.Buffer
type commitMessageChange struct {
Image string
OldTag string
NewTag string
}
type commitMessageTemplate struct {
AppName string
AppChanges []commitMessageChange
}
// We need to transform the change list into something more viable for the
// writer of a template.
changes := make([]commitMessageChange, 0)
for _, c := range changeList {
changes = append(changes, commitMessageChange{c.Image.ImageName, c.OldTag.String(), c.NewTag.String()})
}
tplData := commitMessageTemplate{
AppName: appName,
AppChanges: changes,
}
err := tpl.Execute(&cmBuf, tplData)
if err != nil {
log.Errorf("could not execute template for Git commit message: %v", err)
return "build: update of application " + appName
}
return cmBuf.String()
}
// TemplateBranchName parses a string to a template, and returns a
// branch name from that new template. If a branch name can not be
// rendered, it returns an empty value.
func TemplateBranchName(branchName string, changeList []ChangeEntry) string {
var cmBuf bytes.Buffer
tpl, err1 := template.New("branchName").Parse(branchName)
if err1 != nil {
log.Errorf("could not create template for Git branch name: %v", err1)
return ""
}
type imageChange struct {
Name string
Alias string
OldTag string
NewTag string
}
type branchNameTemplate struct {
Images []imageChange
SHA256 string
}
// Let's add a unique hash to the template
hasher := sha256.New()
// We need to transform the change list into something more viable for the
// writer of a template.
changes := make([]imageChange, 0)
for _, c := range changeList {
changes = append(changes, imageChange{c.Image.ImageName, c.Image.ImageAlias, c.OldTag.String(), c.NewTag.String()})
id := fmt.Sprintf("%v-%v-%v,", c.Image.ImageName, c.OldTag.String(), c.NewTag.String())
_, hasherErr := hasher.Write([]byte(id))
log.Infof("writing to hasher %v", id)
if hasherErr != nil {
log.Errorf("could not write image string to hasher: %v", hasherErr)
return ""
}
}
tplData := branchNameTemplate{
Images: changes,
SHA256: hex.EncodeToString(hasher.Sum(nil)),
}
err2 := tpl.Execute(&cmBuf, tplData)
if err2 != nil {
log.Errorf("could not execute template for Git branch name: %v", err2)
return ""
}
toReturn := cmBuf.String()
if len(toReturn) > 255 {
trunc := toReturn[:255]
log.Warnf("write-branch name %v exceeded 255 characters and was truncated to %v", toReturn, trunc)
return trunc
} else {
return toReturn
}
}
type changeWriter func(app *v1alpha1.Application, wbc *WriteBackConfig, gitC git.Client) (err error, skip bool)
// commitChanges commits any changes required for updating one or more images
// after the UpdateApplication cycle has finished.
func commitChangesGit(app *v1alpha1.Application, wbc *WriteBackConfig, changeList []ChangeEntry, write changeWriter) error {
logCtx := log.WithContext().AddField("application", app.GetName())
creds, err := wbc.GetCreds(app)
if err != nil {
return fmt.Errorf("could not get creds for repo '%s': %v", wbc.GitRepo, err)
}
var gitC git.Client
if wbc.GitClient == nil {
tempRoot, err := os.MkdirTemp(os.TempDir(), fmt.Sprintf("git-%s", app.Name))
if err != nil {
return err
}
defer func() {
err := os.RemoveAll(tempRoot)
if err != nil {
logCtx.Errorf("could not remove temp dir: %v", err)
}
}()
gitC, err = git.NewClientExt(wbc.GitRepo, tempRoot, creds, false, false, "")
if err != nil {
return err
}
} else {
gitC = wbc.GitClient
}
err = gitC.Init()
if err != nil {
return err
}
// The branch to checkout is either a configured branch in the write-back
// config, or taken from the application spec's targetRevision. If the
// target revision is set to the special value HEAD, or is the empty
// string, we'll try to resolve it to a branch name.
checkOutBranch := getApplicationSource(app).TargetRevision
if wbc.GitBranch != "" {
checkOutBranch = wbc.GitBranch
}
logCtx.Tracef("targetRevision for update is '%s'", checkOutBranch)
if checkOutBranch == "" || checkOutBranch == "HEAD" {
checkOutBranch, err = gitC.SymRefToBranch(checkOutBranch)
logCtx.Infof("resolved remote default branch to '%s' and using that for operations", checkOutBranch)
if err != nil {
return err
}
}
// The push branch is by default the same as the checkout branch, unless
// specified after a : separator git-branch annotation, in which case a
// new branch will be made following a template that can use the list of
// changed images.
pushBranch := checkOutBranch
if wbc.GitWriteBranch != "" {
logCtx.Debugf("Using branch template: %s", wbc.GitWriteBranch)
pushBranch = TemplateBranchName(wbc.GitWriteBranch, changeList)
if pushBranch == "" {
return fmt.Errorf("Git branch name could not be created from the template: %s", wbc.GitWriteBranch)
}
}
// If the pushBranch already exists in the remote origin, directly use it.
// Otherwise, create the new pushBranch from checkoutBranch
if checkOutBranch != pushBranch {
fetchErr := gitC.ShallowFetch(pushBranch, 1)
if fetchErr != nil {
err = gitC.ShallowFetch(checkOutBranch, 1)
if err != nil {
return err
}
logCtx.Debugf("Creating branch '%s' and using that for push operations", pushBranch)
err = gitC.Branch(checkOutBranch, pushBranch)
if err != nil {
return err
}
}
} else {
err = gitC.ShallowFetch(checkOutBranch, 1)
if err != nil {
return err
}
}
err = gitC.Checkout(pushBranch, false)
if err != nil {
return err
}
if err, skip := write(app, wbc, gitC); err != nil {
return err
} else if skip {
return nil
}
commitOpts := &git.CommitOptions{}
if wbc.GitCommitMessage != "" {
cm, err := os.CreateTemp("", "image-updater-commit-msg")
if err != nil {
return fmt.Errorf("cold not create temp file: %v", err)
}
logCtx.Debugf("Writing commit message to %s", cm.Name())
err = os.WriteFile(cm.Name(), []byte(wbc.GitCommitMessage), 0600)
if err != nil {
_ = cm.Close()
return fmt.Errorf("could not write commit message to %s: %v", cm.Name(), err)
}
commitOpts.CommitMessagePath = cm.Name()
_ = cm.Close()
defer os.Remove(cm.Name())
}
// Set username and e-mail address used to identify the commiter
if wbc.GitCommitUser != "" && wbc.GitCommitEmail != "" {
err = gitC.Config(wbc.GitCommitUser, wbc.GitCommitEmail)
if err != nil {
return err
}
}
if wbc.GitCommitSigningKey != "" {
commitOpts.SigningKey = wbc.GitCommitSigningKey
}
commitOpts.SigningMethod = wbc.GitCommitSigningMethod
commitOpts.SignOff = wbc.GitCommitSignOff
err = gitC.Commit("", commitOpts)
if err != nil {
return err
}
err = gitC.Push("origin", pushBranch, pushBranch != checkOutBranch)
if err != nil {
return err
}
return nil
}
func writeOverrides(app *v1alpha1.Application, wbc *WriteBackConfig, gitC git.Client) (err error, skip bool) {
logCtx := log.WithContext().AddField("application", app.GetName())
targetExists := true
targetFile := path.Join(gitC.Root(), wbc.Target)
_, err = os.Stat(targetFile)
if err != nil {
if !os.IsNotExist(err) {
return
} else {
targetExists = false
}
}
// If the target file already exist in the repository, we will check whether
// our generated new file is the same as the existing one, and if yes, we
// don't proceed further for commit.
var override []byte
var originalData []byte
if targetExists {
originalData, err = os.ReadFile(targetFile)
if err != nil {
return err, false
}
override, err = marshalParamsOverride(app, originalData)
if err != nil {
return
}
if string(originalData) == string(override) {
logCtx.Debugf("target parameter file and marshaled data are the same, skipping commit.")
return nil, true
}
} else {
override, err = marshalParamsOverride(app, nil)
if err != nil {
return
}
}
dir := filepath.Dir(targetFile)
err = os.MkdirAll(dir, 0700)
if err != nil {
return
}
err = os.WriteFile(targetFile, override, 0600)
if err != nil {
return
}
if !targetExists {
err = gitC.Add(targetFile)
}
return
}
var _ changeWriter = writeOverrides
// writeKustomization writes any changes required for updating one or more images to a kustomization.yml
func writeKustomization(app *v1alpha1.Application, wbc *WriteBackConfig, gitC git.Client) (err error, skip bool) {
logCtx := log.WithContext().AddField("application", app.GetName())
base := filepath.Join(gitC.Root(), wbc.KustomizeBase)
logCtx.Infof("updating base %s", base)
kustFile := findKustomization(base)
if kustFile == "" {
return fmt.Errorf("could not find kustomization in %s", base), false
}
filterFunc, err := imagesFilter(getApplicationSource(app).Kustomize.Images)
if err != nil {
return err, false
}
return updateKustomizeFile(filterFunc, kustFile)
}
// updateKustomizeFile reads the kustomization file at path, applies the filter to it, and writes the result back
// to the file. This is the same behavior as kyaml.UpdateFile, but it preserves the original order of YAML fields
// and indentation of YAML sequences to minimize git diffs.
func updateKustomizeFile(filter kyaml.Filter, path string) (error, bool) {
// Open the input file for read
yRaw, err := os.ReadFile(path)
if err != nil {
return err, false
}
// Read the yaml document from bytes
originalYSlice, err := kio.FromBytes(yRaw)
if err != nil {
return err, false
}
// Check that we are dealing with a single document
if len(originalYSlice) != 1 {
return errors.New("target parameter file should contain a single YAML document"), false
}
originalY := originalYSlice[0]
// Get the (parsed) original document
originalData, err := originalY.String()
if err != nil {
return err, false
}
// Create a reader, preserving indentation of sequences
var out bytes.Buffer
rw := &kio.ByteReadWriter{
Reader: bytes.NewBuffer(yRaw),
Writer: &out,
PreserveSeqIndent: true,
}
// Read from input buffer
newYSlice, err := rw.Read()
if err != nil {
return err, false
}
// We can safely assume we have a single document from the previous check
newY := newYSlice[0]
// Update the yaml
if err := newY.PipeE(filter); err != nil {
return err, false
}
// Preserve the original order of fields
if err := order.SyncOrder(originalY, newY); err != nil {
return err, false
}
// Write the yaml document to the output buffer
if err = rw.Write([]*kyaml.RNode{newY}); err != nil {
return err, false
}
// newY contains metadata used by kio to preserve sequence indentation,
// hence we need to parse the output buffer instead
newParsedY, err := kyaml.Parse(out.String())
if err != nil {
return err, false
}
newData, err := newParsedY.String()
if err != nil {
return err, false
}
// Compare the updated document with the original document
if originalData == newData {
log.Debugf("target parameter file and marshaled data are the same, skipping commit.")
return nil, true
}
// Write to file the changes
if err := os.WriteFile(path, out.Bytes(), 0600); err != nil {
return err, false
}
return nil, false
}
func imagesFilter(images v1alpha1.KustomizeImages) (kyaml.Filter, error) {
var overrides []kyaml.Filter
for _, img := range images {
override, err := imageFilter(parseImageOverride(img))
if err != nil {
return nil, err
}
overrides = append(overrides, override)
}
return kyaml.FilterFunc(func(object *kyaml.RNode) (*kyaml.RNode, error) {
err := object.PipeE(append([]kyaml.Filter{kyaml.LookupCreate(
kyaml.SequenceNode, "images",
)}, overrides...)...)
return object, err
}), nil
}
func imageFilter(imgSet types.Image) (kyaml.Filter, error) {
data, err := kyaml.Marshal(imgSet)
if err != nil {
return nil, err
}
update, err := kyaml.Parse(string(data))
if err != nil {
return nil, err
}
setter := kyaml.ElementSetter{
Element: update.YNode(),
Keys: []string{"name"},
Values: []string{imgSet.Name},
}
return kyaml.FilterFunc(func(object *kyaml.RNode) (*kyaml.RNode, error) {
return object, object.PipeE(setter)
}), nil
}
func findKustomization(base string) string {
for _, f := range konfig.RecognizedKustomizationFileNames() {
kustFile := path.Join(base, f)
if stat, err := os.Stat(kustFile); err == nil && !stat.IsDir() {
return kustFile
}
}
return ""
}
func parseImageOverride(str v1alpha1.KustomizeImage) types.Image {
// TODO is this a valid use? format could diverge
img := image.NewFromIdentifier(string(str))
tagName := ""
tagDigest := ""
if img.ImageTag != nil {
tagName = img.ImageTag.TagName
tagDigest = img.ImageTag.TagDigest
}
if img.RegistryURL != "" {
// NewFromIdentifier strips off the registry
img.ImageName = img.RegistryURL + "/" + img.ImageName
}
if img.ImageAlias == "" {
img.ImageAlias = img.ImageName
img.ImageName = "" // inside baseball (see return): name isn't changing, just tag, so don't write newName
}
return types.Image{
Name: img.ImageAlias,
NewName: img.ImageName,
NewTag: tagName,
Digest: tagDigest,
}
}
var _ changeWriter = writeKustomization
|