summaryrefslogtreecommitdiff
path: root/pkg
diff options
context:
space:
mode:
authorJort Koopmans <jort@jabo-solutions.eu>2024-09-06 02:43:35 +0200
committerGitHub <noreply@github.com>2024-09-05 20:43:35 -0400
commit5990a9b49ca3e09bd91477bf6730c792c4d3cdf2 (patch)
tree930b81c9841f7064a7c246961456fead811d5fee /pkg
parentd8296853e09ab4944646462e680aa5231695638b (diff)
feat: Sync namespace for Event to the Application namespace (#847) (#848)
Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
Diffstat (limited to 'pkg')
-rw-r--r--pkg/kube/kubernetes.go6
-rw-r--r--pkg/kube/kubernetes_test.go2
2 files changed, 4 insertions, 4 deletions
diff --git a/pkg/kube/kubernetes.go b/pkg/kube/kubernetes.go
index 3ec66cf..1158331 100644
--- a/pkg/kube/kubernetes.go
+++ b/pkg/kube/kubernetes.go
@@ -96,14 +96,14 @@ func (client *KubernetesClient) GetSecretField(namespace string, secretName stri
}
}
-// CreateApplicationevent creates a kubernetes event with a custom reason and message for an application.
+// CreateApplicationEvent creates a kubernetes event with a custom reason and message for an application.
func (client *KubernetesClient) CreateApplicationEvent(app *appv1alpha1.Application, reason string, message string, annotations map[string]string) (*v1.Event, error) {
t := metav1.Time{Time: time.Now()}
event := v1.Event{
ObjectMeta: metav1.ObjectMeta{
Name: fmt.Sprintf("%v.%x", app.ObjectMeta.Name, t.UnixNano()),
- Namespace: client.Namespace,
+ Namespace: app.ObjectMeta.Namespace,
Annotations: annotations,
},
Source: v1.EventSource{
@@ -125,7 +125,7 @@ func (client *KubernetesClient) CreateApplicationEvent(app *appv1alpha1.Applicat
Reason: reason,
}
- result, err := client.Clientset.CoreV1().Events(client.Namespace).Create(client.Context, &event, metav1.CreateOptions{})
+ result, err := client.Clientset.CoreV1().Events(app.ObjectMeta.Namespace).Create(client.Context, &event, metav1.CreateOptions{})
if err != nil {
return nil, err
}
diff --git a/pkg/kube/kubernetes_test.go b/pkg/kube/kubernetes_test.go
index 56ca620..35d6922 100644
--- a/pkg/kube/kubernetes_test.go
+++ b/pkg/kube/kubernetes_test.go
@@ -93,6 +93,6 @@ func Test_CreateApplicationEvent(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, event)
assert.Equal(t, "ArgocdImageUpdater", event.Source.Component)
- assert.Equal(t, "default", client.Namespace)
+ assert.Equal(t, "argocd", event.Namespace)
})
}