diff options
| author | Cheng Fang <cfang@redhat.com> | 2025-01-07 11:51:27 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-07 11:51:27 -0500 |
| commit | 9a20452b7fbe84d13a941a19a29d931481c61d88 (patch) | |
| tree | 5bf5e3c87794b40a268978bb3c7b1f1095b6ccae | |
| parent | 2224836b0e829af2a404743857de0e0e664f8cf2 (diff) | |
chore(doc): add description of DCO requirement in contributing.md; remove specific version from Golang the required tool (#999)
| -rw-r--r-- | docs/contributing/development.md | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/docs/contributing/development.md b/docs/contributing/development.md index ef81c5f..0d83fb3 100644 --- a/docs/contributing/development.md +++ b/docs/contributing/development.md @@ -5,7 +5,7 @@ Getting started to develop Argo CD Image Updater shouldn't be too hard. All that is required is a simple build toolchain, consisting of: -* Golang v1.14 +* Golang * GNU make * Docker (for building images, optional) * Kustomize (for building K8s manifests, optional) @@ -38,7 +38,10 @@ If you are running the cmd shell and are running into issues running `make all`, To send a pull request, simply fork the [GitHub repository](https://github.com/argoproj-labs/argocd-image-updater) to your GitHub account, create a new branch, commit & push your changes and then -send the PR over for review. +send the PR over for review. Changes should be +[signed off](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s) +and committed with `-s` or `--signoff` options to meet +[Developer Certificate of Origin](https://probot.github.io/apps/dco/) requirement. When developing new features or fixing bugs, please make sure that your code is accompanied by appropriate unit tests. If you are fixing a bug, please also |