diff options
| author | Cheng Fang <cfang@redhat.com> | 2024-09-11 08:54:10 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-11 08:54:10 -0400 |
| commit | 89a261e96f6866257828dab6e4a7e4a517a7a572 (patch) | |
| tree | ff92007a52e2c1fdce65b5af64fa0c9de85897ed | |
| parent | 60b89f2e5d8cbff4b2052a805256ce385c2fd31c (diff) | |
fix: missing namespace on clusterrolebinding in install manifests (#860)
Signed-off-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: Jann Fischer <jann@mistrust.net>
| -rw-r--r-- | docs/install/installation.md | 8 | ||||
| -rw-r--r-- | manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml | 1 | ||||
| -rw-r--r-- | manifests/install.yaml | 1 |
3 files changed, 10 insertions, 0 deletions
diff --git a/docs/install/installation.md b/docs/install/installation.md index 813d1db..36fe5c9 100644 --- a/docs/install/installation.md +++ b/docs/install/installation.md @@ -28,6 +28,10 @@ Argo CD is running. Don't worry, without any configuration, it will not start me kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml ``` +!!! warning + The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different +namespace then make sure to update the namespace reference. + !!!note "A word on high availability" It is not advised to run multiple replicas of the same Argo CD Image Updater instance. Just leave the number of replicas at 1, otherwise weird side @@ -70,6 +74,10 @@ kubectl create namespace argocd-image-updater kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml ``` +!!! warning + The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different +namespace then make sure to update the namespace reference. + !!!note "A word on high availability" It is not advised to run multiple replicas of the same Argo CD Image Updater instance. Just leave the number of replicas at 1, otherwise weird side diff --git a/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml b/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml index f718710..9d8ec00 100644 --- a/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml +++ b/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml @@ -13,3 +13,4 @@ roleRef: subjects: - kind: ServiceAccount name: argocd-image-updater + namespace: argocd diff --git a/manifests/install.yaml b/manifests/install.yaml index a3ed479..165ac03 100644 --- a/manifests/install.yaml +++ b/manifests/install.yaml @@ -82,6 +82,7 @@ roleRef: subjects: - kind: ServiceAccount name: argocd-image-updater + namespace: argocd --- apiVersion: v1 kind: ConfigMap |