diff options
| author | Eliise <elseling@microsoft.com> | 2020-04-07 04:32:01 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-06 22:32:01 -0500 |
| commit | 62a87c8131130956f60c13e254cb1059d38d0f91 (patch) | |
| tree | a98b6efe482e352c4cb456e65b33e7b59cc6d760 /.github | |
| parent | 8c4b56a80b0bca349c455b5d08c304038551566e (diff) | |
Update dev container with tooling and comments (#256)
* Add tooling and comments
* Fix linter
* Add linter install
* Add workdir back
* Fix workspace not being set
I think this isssue was caused by differences between ubuntu and debian
* Use newer versions
* Use the new linter
* Use the new way to build provider
* Fix typo
* Refactor install command
Co-authored-by: Nicholas M. Iodice <niiodice@microsoft.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/check-pr.yml | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/.github/workflows/check-pr.yml b/.github/workflows/check-pr.yml index 8b52f313..4c22209b 100644 --- a/.github/workflows/check-pr.yml +++ b/.github/workflows/check-pr.yml @@ -63,14 +63,17 @@ jobs: - name: Run Acceptance Tests in Docker run: | - docker run --env AZDO_ORG_SERVICE_URL=${AZDO_ORG_SERVICE_URL} \ + docker run \ + --env AZDO_ORG_SERVICE_URL=${AZDO_ORG_SERVICE_URL} \ --env AZDO_PERSONAL_ACCESS_TOKEN=${AZDO_PERSONAL_ACCESS_TOKEN} \ --env AZDO_GITHUB_SERVICE_CONNECTION_PAT=${AZDO_GITHUB_SERVICE_CONNECTION_PAT} \ --env AZDO_TEST_AAD_USER_EMAIL=${AZDO_TEST_AAD_USER_EMAIL} \ --env AZDO_DOCKERHUB_SERVICE_CONNECTION_USERNAME=${AZDO_DOCKERHUB_SERVICE_CONNECTION_USERNAME} \ --env AZDO_DOCKERHUB_SERVICE_CONNECTION_EMAIL=${AZDO_DOCKERHUB_SERVICE_CONNECTION_EMAIL} \ --env AZDO_DOCKERHUB_SERVICE_CONNECTION_PASSWORD=${AZDO_DOCKERHUB_SERVICE_CONNECTION_PASSWORD} \ - -v ${PWD}:/workspaces/terraform-provider-azuredevops dev ./scripts/acctest.sh + --workdir /workspaces/terraform-provider-azuredevops \ + -v ${PWD}:/workspaces/terraform-provider-azuredevops \ + dev ./scripts/acctest.sh env: AZDO_ORG_SERVICE_URL: ${{ secrets.AZDO_ORG_SERVICE_URL }} AZDO_PERSONAL_ACCESS_TOKEN: ${{ secrets.AZDO_PERSONAL_ACCESS_TOKEN }} |